Page MenuHomePhabricator

Raise $wgAbuseFilterConditionLimit for Meta-Wiki
Closed, DeclinedPublic

Description

Given that Meta-Wiki not only runs local abusefilters, but also global ones on all small and medium-sized wikis plus few others, I'd propose to increase the condition limit to 2000 as in commons (cf. T132048). Some of those filters are quite powerful to prevent abuse on all those wikis and we so far need all of the currently enabled ones.

Revisions and Commits

Event Timeline

Change 313601 had a related patch set uploaded (by MarcoAurelio):
Raise abusefilter condition limit for Meta-Wiki

https://gerrit.wikimedia.org/r/313601

MarcoAurelio added a revision: Restricted Differential Revision.Sep 30 2016, 3:07 PM

I have my doubts that most communities care about how high their condition limit is, seeing as it has (almost) no effect on the actual project and is mostly a technical variable.

I think the same as @JEumerus. Maybe we can announce the change on Meta, but I'm more interested on how can this impact site performance, etc.

I think that some filters are needing a cleanup (https://www.mediawiki.org/wiki/Extension:AbuseFilter/Conditions)

For example we had a filter which has used rlike +20 times instead of simply one regex with multiple (|||).

Then we can evaluate if this is still needed.

By the way: Regarding the Community-consensus-needed question: I see no need, it does not affect the community like adding new tool or changing edit buttons.

Change 313601 merged by jenkins-bot:
Raise abusefilter condition limit for Meta-Wiki

https://gerrit.wikimedia.org/r/313601

Per Z398#7183 was handling this

[02:20] <grrrit-wm> (Merged) jenkins-bot: Raise abusefilter condition limit for Meta-Wiki [mediawiki-config] - https://gerrit.wikimedia.org/r/313601 (https://phabricator.wikimedia.org/T147063) (owner: MarcoAurelio)
[02:20] <addshore> arseny92: is this someting testable on mw1099?
[02:20] <yurik> i want to test it first
[02:20] <addshore> https://gerrit.wikimedia.org/r/313601 is now on mw1099
[02:21] <legoktm> addshore: wait
[02:22] <addshore> ack
[02:22] <legoktm> addshore: sorry, just saw the ticket. Has there been a performance discussion about meta-wiki's abuse filters? I don't think we should be raising the limit just because they asked for it
[02:23] <arseny92> looks like nothing exploded
[02:23] <legoktm> e.g. compare the analysis on https://phabricator.wikimedia.org/T132048 versus the meta-wiki ticket
[02:25] <legoktm> addshore: I'll comment on the ticket, but I don't think it should be raised right now.
[02:25] <addshore> There should be less of an impact for meta, but if we think we want to look at this more I can revert it for now
[02:25] <addshore> ack, will revert it for now.
[02:25] <grrrit-wm> (PS1) Addshore: Revert "Raise abusefilter condition limit for Meta-Wiki" [mediawiki-config] - https://gerrit.wikimedia.org/r/318014 
[02:25] <grrrit-wm> (CR) Addshore: [C: 2] Revert "Raise abusefilter condition limit for Meta-Wiki" [mediawiki-config] - https://gerrit.wikimedia.org/r/318014 (owner: Addshore)
[02:26] <grrrit-wm> (Merged) jenkins-bot: Revert "Raise abusefilter condition limit for Meta-Wiki" [mediawiki-config] - https://gerrit.wikimedia.org/r/318014 (owner: Addshore)
[02:26] <addshore> 1099 now has the revert too.

I think that some filters are needing a cleanup (https://www.mediawiki.org/wiki/Extension:AbuseFilter/Conditions)

For example we had a filter which has used rlike +20 times instead of simply one regex with multiple (|||).

Then we can evaluate if this is still needed.

By the way: Regarding the Community-consensus-needed question: I see no need, it does not affect the community like adding new tool or changing edit buttons.

I think this is absolutely right - I think before the limit is raised, the Meta-Wiki community needs to re-assess their filters, optimize them, and then come back with proof demonstrating that a higher limit is needed. Compare to the work Commons (and MatmaRex in particular) did before they raised the condition limit on T132048. I believe that should be done before we raise the limit. And that was why I asked @Addshore not to deploy the patch during SWAT today when I saw it go by in IRC.

One thing we can do is turn on the AF profiling temporarily to assist with debugging and identifying slow filters/code like was done for Commons as well.

That's okay. Maybe someone with good knowledge about abusefilter syntax can help us do so. If the AF profiling (links/explanation please?) will also help, then please enable it as well.

MarcoAurelio changed the task status from Open to Stalled.Nov 7 2016, 5:43 PM
MarcoAurelio triaged this task as Low priority.

If we need this again feel free to reopen.

For the record, the condition limit has been recently increased to 2000 for all wikis: T309609.