Page MenuHomePhabricator

Add CI job Oozie XML stylesheet validation for the analytics/refinery repository
Open, LowestPublic

Description

I recently submitted a patch to the analytics/refinery repo in gerrit and it has no jenkins tests/lints enabled. I wonder if they should have some. Thanks.

Event Timeline

hashar subscribed.

Which repository and Gerrit change?

The analytics/refinery/source.git repository has a maven job and it should be running:

- name: analytics/refinery/source
  test:
   - analytics-refinery-maven
  gate-and-submit:
   - analytics-refinery-maven
hashar triaged this task as Medium priority.Sep 30 2016, 3:07 PM
hashar moved this task from Backlog to Repo setup on the Continuous-Integration-Config board.

Ah that is for analytics/refinery.git Looks like it is related to T130123 by @madhuvishy

rCICFc025b416611a:

Add job that allows for updating analytics refinery artifacts with latest source jars Given a version number - this job fetches the latest analytics/refinery/source jars from archiva and commits to the source of analytics/refinery's artifacts, and pushes to gerrit. It can be triggered from - https://integration.wikimedia.org/ci/job/analytics-refinery-update-jars/build

For the rest of the repository, I have no idea what kind of automatic tests the analytics/refinery.git repo can benefit from.

My patch is unrelated to this, and is specifically only for a step in the refinery deployment process. Not sure if the rest of the repo needs tests - Pinging @JAllemandou who may know better.

Ottomata subscribed.

It might be nice to have Oozie XML stylesheet validation as a jenkins job, but this would be so low priority that we would never work on it.

Is it hard to get that XML thing? If not I might be able to upload a patch
for that. Keep this closed, but I'll try to learn about that and if I
succeed; I may reopen this. Thanks!

MarcoAurelio renamed this task from Jenkins tests for analytics/refinery? to Add CI job Oozie XML stylesheet validation for the analytics/refinery repository.Nov 28 2016, 4:46 PM
MarcoAurelio reopened this task as Open.
MarcoAurelio lowered the priority of this task from Medium to Lowest.

I've reopened because I plan to investigate how to add this job in ligh of recent commits I've submitted to that repo. It's said above that it'd be nice to have such a test and Phabricator certainly allows prioritizing of tasks as "lowest" so since this is a valid task that can be acomplished in the future I've taken the liberty to reopen this one. Hope that you don't mind. Regards.

Dropping Continuous-Integration-Config . CI is configured to run maven and adding Oozie should be done via the project pom.xml.

Restricted Application edited projects, added Analytics; removed Analytics-Radar. · View Herald TranscriptJun 10 2020, 6:33 AM
Restricted Application edited projects, added Analytics; removed Analytics-Radar. · View Herald TranscriptJun 10 2020, 6:36 AM