Page MenuHomePhabricator

Unprotecting a non-protected page leaves a log entry
Closed, ResolvedPublic


It's possible to "unprotect" a page without protection ever having been set. If you use &action=unprotect on a page and confirm the protection, it leaves a log entry.

Generally this wouldn't really matter, however, people sometimes use scripts and they accidentally hit the wrong button / link, causing an awkward log entry.

Version: unspecified
Severity: enhancement



Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:07 PM
bzimport set Reference to bz12716.
bzimport added a subscriber: Unknown Object (MLST).

overlordq wrote:

change to Title.php

A change similar to r30020 to check the return of the SQL UPDATE/DELETE of Title Protection should fix this?

Tests 1-4 before patch, tests 5-12 after.


sxwiki wrote:

Confirmed this behavior on my testwiki, and, confirmed the patch as working.


Still having this issue. See .

I set an expiry and a protection reason and clicked confirm, which logged the unprotection, even though the page was never protected.