Page MenuHomePhabricator

[Crash] BadTokenException in ViewRootImpl.setView()
Closed, ResolvedPublic1 Estimated Story Points

Description

Reproduced on my Samsung Galaxy S7 (Android 6.1)!

  • Navigate to an article
  • Press-and-hold to highlight some text in the article (make sure the floating ActionMode appears)
  • Click the "x" button in the toolbar to close the page

Seems to be 100% Samsung-specific and 100% limited to Android 6.0.1. :(

https://rink.hockeyapp.net/manage/apps/226649/app_versions/76/crash_reasons/138566597

android.view.WindowManager$BadTokenException: Unable to add window -- token null is not valid; is your activity running?
at android.view.ViewRootImpl.setView(ViewRootImpl.java:849)
at android.view.WindowManagerGlobal.addView(WindowManagerGlobal.java:337)
at android.view.WindowManagerImpl.addView(WindowManagerImpl.java:91)
at android.widget.PopupWindow.invokePopup(PopupWindow.java:1329)
at android.widget.PopupWindow.showAtLocation(PopupWindow.java:1077)
at android.widget.PopupWindow.showAtLocation(PopupWindow.java:1035)
at com.android.internal.widget.FloatingToolbar$FloatingToolbarPopup.show(FloatingToolbar.java:561)
at com.android.internal.widget.FloatingToolbar.show(FloatingToolbar.java:212)
at com.android.internal.view.FloatingActionMode$FloatingToolbarVisibilityHelper.updateToolbarVisibility(FloatingActionMode.java:411)
at com.android.internal.view.FloatingActionMode$1.run(FloatingActionMode.java:65)
at android.os.Handler.handleCallback(Handler.java:739)
at android.os.Handler.dispatchMessage(Handler.java:95)
at android.os.Looper.loop(Looper.java:158)
at android.app.ActivityThread.main(ActivityThread.java:7224)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:1230)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1120)

Event Timeline

Change 315288 had a related patch set uploaded (by Dbrant):
Fix possible crash on Samsung devices.

https://gerrit.wikimedia.org/r/315288

Change 315288 merged by jenkins-bot:
Fix possible crash on Samsung devices.

https://gerrit.wikimedia.org/r/315288