Page MenuHomePhabricator

Remove inline styling from BlogPage
Closed, InvalidPublic

Description

Result of a grep ran by ashley in T87148#1523869:

./BlogPage/SpecialCreateBlogPost.php: $this->tabCounter . '" name="title2" id="title" style="width: 500px;"><br /><br />';
./BlogPage/SpecialCreateBlogPost.php: $tagcloud .= " <span id=\"tag-{$tagnumber}\" style=\"font-size:{$cloud->tags[$tag]['size']}{$cloud->tags_size_type}\">

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 4 2016, 2:46 AM
SamanthaNguyen moved this task from Backlog to BlogPage on the Social-Tools board.Oct 4 2016, 3:27 AM
SamanthaNguyen moved this task from Backlog to Feedback on the BlogPage board.Oct 4 2016, 3:34 AM

Of the two cases listed above, only the bottom still seems to exist in the code, and that can't be moved into CSS due to the PHP stuff, so I suggest this is closed?

Change 328920 had a related patch set uploaded (by UltrasonicNXT):
Remove inline styling

https://gerrit.wikimedia.org/r/328920

oops, wrong bug number, you can ignore that gerritbot message

@SamanthaNguyen what do you think about closing this as the top case listed above no longer exists in the code, and the bottom one can't be moved into CSS due to the PHP in it?

Sorry, I was on mobile earlier and I didn't see a textarea - turns out there was! anyways, I think it's fine to close this, so I'll mark this ticket as INVALID.

SamanthaNguyen closed this task as Invalid.Dec 23 2016, 8:35 PM