Page MenuHomePhabricator
Create Task
Maniphest T147350

Change Python hashbang to `#! /usr/bin/env python -E -s` for user-facing tools
Closed, ResolvedPublic
Actions

Description

-E ignores the PYTHONPATH environment variable, while -s ignores the user-packages directory. This prevents confusion such as in T144554: BUB 503: AttributeError: 'module' object has no attribute 'python_2_unicode_compatible'.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
webservice: Fix #!...operations/software/tools-webservicemaster+2 -2
jsub: Fix #!... to actually worklabs/toollabsmaster+1 -1
jsub: guard against PYTHONPATH munging in caller's environmentlabs/toollabsmaster+11 -3
webservice: guard against PYTHONPATH munging in caller's environmentoperations/software/tools-webservicemaster+8 -2
Customize query in gerrit

Related Objects

Event Timeline

valhallasw created this task.Oct 4 2016, 7:52 PM
Restricted Application added a project: Cloud-Services. · View Herald TranscriptOct 4 2016, 7:52 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
valhallasw added a comment.Oct 4 2016, 7:54 PM

In addition, -E -s makes webservice start much faster if PYTHONPATH refers to a directory on NFS; the user-packages directory is always on NFS and therefore always slow.

gerritbot subscribed.Nov 21 2016, 11:21 PM

Change 322790 had a related patch set uploaded (by BryanDavis):
jsub: guard against PYTHONPATH munging in caller's environment

https://gerrit.wikimedia.org/r/322790

gerritbot added a project: Patch-For-Review.Nov 21 2016, 11:21 PM
gerritbot added a comment.Nov 21 2016, 11:50 PM

Change 322799 had a related patch set uploaded (by BryanDavis):
webservice: guard against PYTHONPATH munging in caller's environment

https://gerrit.wikimedia.org/r/322799

gerritbot added a comment.Nov 22 2016, 3:19 AM

Change 322799 merged by jenkins-bot:
webservice: guard against PYTHONPATH munging in caller's environment

https://gerrit.wikimedia.org/r/322799

gerritbot added a comment.Nov 22 2016, 3:19 AM

Change 322790 merged by jenkins-bot:
jsub: guard against PYTHONPATH munging in caller's environment

https://gerrit.wikimedia.org/r/322790

scfc closed this task as Resolved.Nov 26 2016, 11:38 PM
scfc assigned this task to • bd808.
Restricted Application added a project: User-bd808. · View Herald TranscriptNov 26 2016, 11:38 PM
scfc reopened this task as Open.Dec 1 2016, 9:52 PM
scfc subscribed.

The packages still need to be built and deployed.

• bd808 added a subscriber: yuvipanda.Dec 1 2016, 9:58 PM

Thanks @scfc. @yuvipanda reminded me of this but I had not dug up the task and reopened it yet. I'll get this done "soon".

• bd808 triaged this task as High priority.Dec 1 2016, 9:58 PM
scfc removed a project: Patch-For-Review.Dec 4 2016, 5:13 PM
scfc moved this task from Backlog to In Progress on the Toolforge board.
scfc mentioned this in T144554: BUB 503: AttributeError: 'module' object has no attribute 'python_2_unicode_compatible'.Dec 5 2016, 5:12 AM
gerritbot added a comment.Dec 5 2016, 10:26 PM

Change 325431 had a related patch set uploaded (by BryanDavis):
jsub: Fix #!... to actually work

https://gerrit.wikimedia.org/r/325431

gerritbot added a project: Patch-For-Review.Dec 5 2016, 10:26 PM
gerritbot added a comment.Dec 5 2016, 10:43 PM

Change 325431 merged by jenkins-bot:
jsub: Fix #!... to actually work

https://gerrit.wikimedia.org/r/325431

Stashbot subscribed.Dec 5 2016, 10:52 PM

Mentioned in SAL (#wikimedia-labs) [2016-12-05T22:52:46Z] <bd808> Updated jobutils to 1.17 on tools-bastion-02 (T147350)

Stashbot added a comment.Dec 5 2016, 10:52 PM

Mentioned in SAL (#wikimedia-labs) [2016-12-05T22:52:56Z] <bd808> Updated jobutils to 1.17 on tools-bastion-03 (T147350)

Stashbot added a comment.Dec 5 2016, 10:53 PM

Mentioned in SAL (#wikimedia-labs) [2016-12-05T22:53:08Z] <bd808> Updated jobutils to 1.17 on tools-cron-01 (T147350)

Stashbot added a comment.Dec 5 2016, 10:53 PM

Mentioned in SAL (#wikimedia-labs) [2016-12-05T22:53:41Z] <bd808> Updated jobutils to 1.17 on tools-precise-dev (T147350)

Stashbot added a comment.Dec 5 2016, 10:55 PM

Mentioned in SAL (#wikimedia-labs) [2016-12-05T22:55:10Z] <bd808> Updated jobutils to 1.17 on tools-mail (T147350)

gerritbot added a comment.Dec 5 2016, 10:59 PM

Change 325436 had a related patch set uploaded (by BryanDavis):
webservice: Fix #!...

https://gerrit.wikimedia.org/r/325436

gerritbot added a comment.Dec 5 2016, 11:06 PM

Change 325436 merged by jenkins-bot:
webservice: Fix #!...

https://gerrit.wikimedia.org/r/325436

Stashbot added a comment.Dec 5 2016, 11:19 PM

Mentioned in SAL (#wikimedia-labs) [2016-12-05T23:19:22Z] <bd808> Updated toollabs-webservice to 0.31 on tools-bastion-02 (T147350)

Stashbot added a comment.Dec 6 2016, 12:36 AM

Mentioned in SAL (#wikimedia-labs) [2016-12-06T00:36:50Z] <bd808> Updated toollabs-webservice to 0.31 on rest of cluster (T147350)

• bd808 closed this task as Resolved.Dec 6 2016, 12:49 AM

Packages have been built and deployed.

• bd808 moved this task from To Do to Done on the User-bd808 board.Jan 7 2017, 12:19 AM
• bd808 moved this task from Done to Archive on the User-bd808 board.
• Phabricator_maintenance removed a subscriber: yuvipanda.Jun 7 2017, 6:40 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits