Page MenuHomePhabricator
Create Task
Maniphest T147392

Hook ShowRawCssJs is deprecated
Closed, ResolvedPublic
Actions

Description

Hook ShowRawCssJs is deprecated

Details

SubjectRepoBranchLines +/-
Make ShowRawCssJs hook emit deprecated warningsmediawiki/coremaster+6 -5
Customize query in gerrit

Related Objects
Search...

Event Timeline

Reedy created this task.Oct 5 2016, 12:26 AM
Legoktm subscribed.Oct 5 2016, 11:21 PM

There should be no uses of this since it was just for SyntaxHighlight, but it should be marked as deprecated since 1.24 since that's when the replacement hook was introduced.

gerritbot subscribed.Oct 6 2016, 1:39 PM

Change 314552 had a related patch set uploaded (by Reedy):
Make ShowRawCssJs hook emit deprecated warnings

https://gerrit.wikimedia.org/r/314552

gerritbot added a project: Patch-For-Review.Oct 6 2016, 1:39 PM
Reedy added a comment.Oct 6 2016, 1:39 PM

Done above, no other usages seen in WMF hosted extensions

Jdforrester-WMF assigned this task to Reedy.Oct 6 2016, 10:49 PM
gerritbot added a comment.Oct 6 2016, 10:57 PM

Change 314552 merged by jenkins-bot:
Make ShowRawCssJs hook emit deprecated warnings

https://gerrit.wikimedia.org/r/314552

ReleaseTaggerBot added projects: MW-1.28-release (WMF-deploy-2016-10-11_(1.28.0-wmf.22)), MW-1.28-release-notes.Oct 6 2016, 11:00 PM
Jdforrester-WMF closed this task as Resolved.Oct 6 2016, 11:04 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL