Page MenuHomePhabricator
Create Task
Maniphest T147398

Keeping suggestions for later does not work
Closed, ResolvedPublic
Actions

Description

Suggestions in Content translaiton can be kept for later by clicking on the "star" icon. Recently, when clicking on it, the suggestion just disappears instead of being added to the list of favourites:

not-saving-for-later.gif (408×700 px, 1 MB)

This makes users lose access to translations they were interested in translating, achieving just the opposite the functionality was intended for.

Related Objects

Event Timeline

Pginer-WMF created this task.Oct 5 2016, 8:15 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 5 2016, 8:15 AM
Pginer-WMF added a comment.Oct 5 2016, 8:18 AM

This was reported originally in this conversation.

KartikMistry subscribed.Oct 6 2016, 2:31 PM

I can reproduce this.

Error in console (example):

XMLHttpRequest cannot load https://recommend.wmflabs.org/api?s=en&t=gu&article=Bhujia+Fort%7CRadheshyam+Sharma%7CGohilwad+Timbo&search=morelike&application=CX. No 'Access-Control-Allow-Origin' header is present on the requested resource. Origin 'https://gu.wikipedia.org' is therefore not allowed access.

I also got:

Use of the "edit" token is deprecated. Use "csrf" instead.

Amire80 triaged this task as High priority.Oct 6 2016, 2:33 PM
Amire80 added a project: Essential-Work.
Amire80 added a project: Language-Engineering October-December 2016.
Amire80 subscribed.

High-prio because this is essentially data loss.

• santhosh added a subscriber: • ellery.Oct 7 2016, 6:59 AM
• santhosh subscribed.

@ellery Any recent change CORS created this issue?

• santhosh added a comment.Oct 7 2016, 7:12 AM

The error related to CORS is T147621: Recommendation tool not accepting 'wiki' search algorithm The original bug description of this ticket does not look related to this CORS issue,

Amire80 moved this task from Needs Triage to Oct.-Dec. 2016 on the ContentTranslation board.Oct 9 2016, 12:28 PM
Arrbee moved this task from Backlog to CX-Maintenance on the Language-Engineering October-December 2016 board.Oct 14 2016, 5:49 AM
Liuxinyu970226 subscribed.Mar 19 2017, 12:24 PM
Amire80 added a comment.May 8 2017, 1:12 PM

This seems to work now. Can this be closed?

Amire80 closed this task as Resolved.Jun 25 2017, 7:37 PM
Amire80 claimed this task.
Liuxinyu970226 unsubscribed.Jun 26 2017, 11:57 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL