Page MenuHomePhabricator

Fatal error in TimedMediaHandler
Closed, ResolvedPublic

Description

Since 1.28.0-wmf.21 this error appears :

Fatal error: Cannot access empty property in /srv/mediawiki/php-1.28.0-wmf.21/extensions/TimedMediaHandler/handlers/TextHandler/TextHandler.php on line 292

seems to be caused by https://phabricator.wikimedia.org/rETMH301f80fc1cf267f51fc13c8cc4d8f93b21a20fb3

Related Objects

Event Timeline

greg triaged this task as Unbreak Now! priority.Oct 5 2016, 6:06 PM
greg added subscribers: brion, greg.

Pinging author and +2'er: @TheDJ and @brion

Fatals in logstash over the last 2 days: https://logstash.wikimedia.org/goto/23ba64f891183783e0c7f1127aa4bcae

So it looks like it should be fine:

class TextHandler {
	// lazy init remote Namespace number
	public $remoteNs = null;
	public $remoteNsName = null;

...

line 292:

		if ( $this->$remoteNs !== null ) {

I don't really see how this can fail...?

Change 314315 had a related patch set uploaded (by Brion VIBBER):
Regression fix: fatal error in TextHandler

https://gerrit.wikimedia.org/r/314315

Change 314316 had a related patch set uploaded (by Brion VIBBER):
Regression fix: fatal error in TextHandler

https://gerrit.wikimedia.org/r/314316

Change 314315 abandoned by Brion VIBBER:
Regression fix: fatal error in TextHandler

Reason:
race condition :D

https://gerrit.wikimedia.org/r/314315

Change 314316 abandoned by Brion VIBBER:
Regression fix: fatal error in TextHandler

Reason:
race condition :D

https://gerrit.wikimedia.org/r/314316

demon claimed this task.