ApiSandbox labels for optional parameters are grayed out
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	matmarex
	Oct 5 2016, 5:33 PM

Description

ApiSandbox labels for optional parameters are grayed out. This is probably caused by 5c8f9d8a4ce7e4a1ba8745d3c17b4540ee006286 in OOjs UI.

The labels also don't get un-grayed when the widget's checkbox is toggled:

I haven't looked at the code in a while, but this makes me think ApiSandbox does some pretty weird things to those FieldLayouts.

	Subject	Repo	Branch	Lines +/-
	ApiSandbox: Ungrey the field label before disabling field label greying	mediawiki/core	master	+1 -0

Mentioned Here: rGOJU5c8f9d8a4ce7: Fix visual disabled state on Radio- and CheckboxInputWidget's labels

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 5 2016, 5:33 PM

The only unusual thing AFAIK is that it sets the FieldLayout's onFieldDisable to a do-nothing function to try to prevent the greying out.

Change 314308 had a related patch set uploaded (by Anomie):
ApiSandbox: Ungrey the field label before disabling field label greying

Change 314308 merged by jenkins-bot:
ApiSandbox: Ungrey the field label before disabling field label greying

Anomie closed this task as Resolved.Oct 5 2016, 6:11 PM

Anomie claimed this task.