ConfirmAccount broken in REL1_27: Call to undefined method MediaWiki\MediaWikiServices::getDBLoadBalancerFactory()
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Ciencia_Al_Poder
	Oct 5 2016, 8:10 PM

Description

Originally reported by Ulfr on IRC.

/ConfirmAccount/business/ConfirmAccountPreAuthenticationProvider.php: Call to undefined method MediaWiki\MediaWikiServices::getDBLoadBalancerFactory()

There's indeed a call to MediaWikiServices::getInstance()->getDBLoadBalancerFactory(); on line 117:

https://phabricator.wikimedia.org/diffusion/ECAC/browse/REL1_27/business/ConfirmAccountPreAuthenticationProvider.php;1125a79fd08d0040e66483191856b22d37bee8bd$119

But getDBLoadBalancerFactory is not defined on MediaWikiServices nor its parent class:

https://phabricator.wikimedia.org/diffusion/MW/browse/REL1_27/includes/MediaWikiServices.php

Details

Subject	Repo	Branch	Lines +/-
Allow reset of global services (redux).	mediawiki/core	REL1_27	+1 K -137
Replaced MediaWikiServices::getInstance with wfGetLBFactory	mediawiki/extensions/ConfirmAccount	REL1_27	+1 -1
Merge commit 'd7410db' into REL1_27	mediawiki/core	REL1_27	+7 -9

Customize query in gerrit

Related Objects

Mentioned Here: rMWd7410db0fdf9: Allow reset of global services (redux).
rECAC4db95fcc5d48: Handle AuthManager introduction to core

Event Timeline

Ciencia_Al_Poder created this task.Oct 5 2016, 8:10 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 5 2016, 8:10 PM

Code added by @aaron in rECAC4db95fcc5d486fa8d48a9374a76c3ed93cf306be

Maybe it was incorrectly backported to REL1_27 in https://gerrit.wikimedia.org/r/#/c/305847/

@Ciencia_Al_Poder nope, if he didn't backport it to REL1_27 then the extension would still be broken.

Change 314420 had a related patch set uploaded (by Paladox):
Merge commit 'd7410db' into REL1_27

https://gerrit.wikimedia.org/r/314420

gerritbot added a project: Patch-For-Review.Oct 5 2016, 9:15 PM

Change 314425 had a related patch set (by Paladox) published:
Replaced MediaWikiServices::getInstance with wfGetLBFactory

https://gerrit.wikimedia.org/r/314425

Change 314420 abandoned by Paladox:
Merge commit 'd7410db' into REL1_27

Reason:
Done here https://gerrit.wikimedia.org/r/314572

https://gerrit.wikimedia.org/r/314420

Change 314572 had a related patch set uploaded (by Paladox):
Allow reset of global services (redux).

https://gerrit.wikimedia.org/r/314572

aaron removed aaron as the assignee of this task.Oct 8 2016, 10:48 PM

Change 314425 merged by jenkins-bot:
Replaced MediaWikiServices::getInstance with wfGetLBFactory

https://gerrit.wikimedia.org/r/314425

Thanks Paladox

Your welcome :)

Change 314572 abandoned by Paladox:
Allow reset of global services (redux).