Use SnakFormatter::FORMAT_PLAIN for the current output of client data access functionality
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	hoo
	Oct 6 2016, 5:28 PM

Description

And escape wikitext as needed.

Details

	Subject	Repo	Branch	Lines +/-
	BinaryOptionDispatchingSnakFormatter fails on unknown properties	mediawiki/extensions/Wikibase	master	+35 -16
	Use FORMAT_PLAIN for data access output	mediawiki/extensions/Wikibase	master	+56 -10

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	thiemowmde	T142940 Create client functionality for getting human readable wikitext from Wikibase statements
Resolved	thiemowmde	T142941 Create a {{#statements:…}} parser function for human readable access to statements
Resolved	hoo	T147568 Create regression tests for the output of client data access functionality
Resolved	hoo	T147580 Use SnakFormatter::FORMAT_PLAIN for the current output of client data access functionality

Event Timeline

hoo created this task.Oct 6 2016, 5:28 PM

hoo added a parent task: T147568: Create regression tests for the output of client data access functionality.

hoo moved this task from Proposed to Doing on the Wikidata-Sprint-2016-09-21 board.

Why not FORMAT_WIKITEXT?

In T147580#2697656, @daniel wrote:

Why not FORMAT_WIKITEXT?

Because we want to use FORMAT_WIKI to deliver actual wiki text (and not just wikitext escaped plain text).

The migration path is: Make current things use format plain, enhance format wiki (link entity ids, …), create new functionality that uses format wiki (while leaving the old functionality intact).

Prerequisite for this: https://gerrit.wikimedia.org/r/314597.

Change 314610 had a related patch set uploaded (by Hoo man):
Use FORMAT_PLAIN for data access output

https://gerrit.wikimedia.org/r/314610

gerritbot added a project: Patch-For-Review.Oct 6 2016, 10:21 PM

hoo moved this task from Doing to Review on the Wikidata-Sprint-2016-09-21 board.Oct 6 2016, 10:22 PM

Change 314610 merged by jenkins-bot:
Use FORMAT_PLAIN for data access output

https://gerrit.wikimedia.org/r/314610

hoo closed this task as Resolved.Oct 7 2016, 3:08 PM

hoo moved this task from Review to Done on the Wikidata-Sprint-2016-09-21 board.

hoo removed a project: Patch-For-Review.

Change 321668 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
BinaryOptionDispatchingSnakFormatter fails on unknown properties

https://gerrit.wikimedia.org/r/321668

gerritbot added a project: Patch-For-Review.Nov 15 2016, 3:19 PM

Change 321668 merged by jenkins-bot:
BinaryOptionDispatchingSnakFormatter fails on unknown properties