Page MenuHomePhabricator
Create Task
Maniphest T147582

Rename the Semantic Forms extension to "Page Forms"
Closed, DeclinedPublic
Actions

Description

Hi,

After much thought and consultation, I've decided that I want to rename my extension, Semantic Forms, to "Page Forms". (Short explanation: Semantic Forms was originally created as a spin-off extension of Semantic MediaWiki, but now can run as an independent extension.)

As far as I know, the renaming has to be done in three places:

Of course, a lot of pages on mediawiki.org as well will have to be moved and modified, but I can take care of that part.

And ideally, the old URLs will redirect to the new ones wherever possible. Most importantly, I want people to keep being able to do "git pull" in their repositories, without having to create a new repository.

That's what I would like done, and whenever it can be done is fine with me. Please let me know if there are any questions/issues.

Thank you,
Yaron

Details

Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
Paladox moved this task from Bugs & stuff to Repo Admin on the Gerrit board.Oct 7 2016, 7:51 AM
Yaron_Koren added a comment.Oct 7 2016, 12:36 PM

@Peachey88 - "Page Forms"; all of my extensions' names contain spaces. Although as far as I know, on Git/Gerrit and Phabricator the spaces are taken out anyway, so maybe it doesn't really matter...

@Paladox - ah, okay. Well, that sounds fine too... this way, I guess, someone staying on the current "SF" repository will just stay on the current set of code. It's a reasonable way to encourage people to switch over without breaking anyone's installation.

Peachey88 added a comment.Oct 8 2016, 1:36 AM

@Yaron_Koren: Phab project renamed, to MediaWiki-extensions-Page_Forms (We swap spaces with either - or _) and aliases setup for mediawiki-extensions-SemanticForms

Peachey88 updated the task description. (Show Details)Oct 8 2016, 1:36 AM
Paladox added a comment.EditedOct 12 2016, 7:56 AM

I've requested that Page Forms be created here https://www.mediawiki.org/wiki/Git/New_repositories/Requests and ask for it to be imported from SemanticForms.

Yaron_Koren added a comment.Oct 13 2016, 6:02 PM

@Paladox - thank you!

Paladox added a comment.Oct 13 2016, 6:03 PM

@Yaron_Koren your welcome.

QChris subscribed.Oct 19 2016, 9:48 AM

Sorry for the late reply.

I want people to keep being able to do "git pull" in their repositories, without having to create a new repository

That part won't work out, as Gerrit does not allow to rename projects.
All we can do is hide the old project, and create a new one.

So existing contributors would need to clone the new repo afresh (or update the corresponding remote).

@Yaron_Koren: Given that limitation ... should we hide the SemanticForms extension in Gerrit and re-add the repo as PageForms?

Yaron_Koren added a comment.Oct 19 2016, 10:44 AM

@QChris - right, that's what Paladox said too. I like his suggestion of making the current repository read-only. Which I guess is your suggestion too - although I don't know what you mean by "hide". How would a hidden repository work differently from a visible one?

Paladox added a comment.Oct 19 2016, 10:47 AM

@Yaron_Koren yes a hidden repo acts differently, it's hidden but wont break gerrit.

Also git clone will not work on that repo.

But what we can do on phabricator diffusion is change the import link to PageForms, so you have two compatible repos, just SemanticForms will be read only on phabricator since we only would need PageForms.

Yaron_Koren added a comment.Oct 19 2016, 1:18 PM

I think for the time being, it's better to keep the Semantic Forms repository visible and working normally (other than being read-only), to avoid any strange issues. (Eventually, it'll be good to make it hidden, and then of course remove it entirely, though probably not for a while.)

What's the import link?

Paladox added a comment.Oct 19 2016, 1:53 PM

The import link would be the anonymous git clone link for this repo. We cannot remove the remove even in the future.

But you can control weather to put the repo into read only or hidden since you have access to the repo on gerrit

Yaron_Koren added a comment.Oct 19 2016, 2:11 PM

Okay. I still don't fully understand, but basically whatever you want to do is fine - as long as people who are using the Semantic Forms repository don't get an error if they call "git pull".

Paladox added a comment.Oct 19 2016, 2:19 PM

Ok, READ ONLY mode then, @Yaron_Koren you can do that when ever the PageForms repo is created.

By going to https://gerrit.wikimedia.org/r/#/admin/projects/mediawiki/extensions/SemanticForms and going to Staud: and selecting the read only option.

Doint forget to update the description pointing to the new renamed repo.

Yaron_Koren added a comment.Oct 19 2016, 2:33 PM

Yes... I'll have to update quite a bit!

QChris added a comment.Oct 19 2016, 10:15 PM

Created in Gerrit as mediawiki/extensions/PageForms

(I did not mess with the SemanticForms repo, as it seems you'll do that yourself. If you need help with that or want me to do let me know)

Paladox added a comment.Oct 19 2016, 10:16 PM

Thankyou.

gerritbot subscribed.Oct 19 2016, 10:22 PM

Change 316907 had a related patch set uploaded (by Paladox):
Update Name of extension to PageForms

https://gerrit.wikimedia.org/r/316907

gerritbot added a project: Patch-For-Review.Oct 19 2016, 10:22 PM
Paladox added a comment.Oct 19 2016, 10:24 PM

@Yaron_Koren as this is a wmf deployed extension, do we need another security review.

We will also need to update the configs in wmf too.

Paladox mentioned this in rEPFM13615989843f: Update Name of extension to PageForms.Oct 19 2016, 10:24 PM
gerritbot added a comment.Oct 19 2016, 10:27 PM

Change 316908 had a related patch set uploaded (by Paladox):
[PageForms] Adding jenkins tests

https://gerrit.wikimedia.org/r/316908

Paladox mentioned this in rEPFM4fb042cc4373: Update Name of extension to PageForms.Oct 19 2016, 10:33 PM
Paladox added a comment.Oct 19 2016, 10:33 PM

@Yaron_Koren one problem though user will need to clone PageForms to get the current code since SemanticForms wont be updated any more.

Yaron_Koren added a comment.Oct 20 2016, 12:53 AM

@QChris - thank you! As long as the Semantic Forms repository is now read-only, I think everything there is all set. Although - where can I find the new repository in Diffusion?

@Paladox - thank you also! No idea about the security review. And yes, every current SF user will eventually have to do some manual work if they want to stick with the extension; I don't think there's any way around that.

• MZMcBride subscribed.Oct 20 2016, 5:17 AM
Paladox added a comment.Oct 20 2016, 7:10 AM

I would think a simple config if up on wmf end. What we should do is kee SemanticForms updated for now and
Rename the files in PageForms and then update translatewiki once we're ready and everything is working and start using that repo.

Paladox added a comment.Oct 20 2016, 7:15 AM

@Yaron Kpren could you create a task for updating from SemanticForms to PageForms on wmf please?

Yaron_Koren added a comment.Oct 20 2016, 1:36 PM

@Paladox - I don't know what you mean by "keep SemanticForms updated". I hope that repository is read-only already! Otherwise, any changes made to it will be wasted.

It seems too early to create an update task... Page Forms is nowhere near ready yet.

Aklapper added a comment.Oct 20 2016, 2:11 PM
In T147582#2730149, @Paladox wrote:

@Yaron_Koren as this is a wmf deployed extension, do we need another security review.

@Paladox: How is your question related to this task about renaming an extension?

Paladox added a comment.Oct 20 2016, 2:13 PM

@Aklapper well because SemanticForms is a wmf extension it won't be updated and likely break. So we need to switch wmf at the same time too.

Aklapper added a comment.Oct 20 2016, 2:37 PM

@Paladox: My question was about your comment about "needing another security review". You did not answer why you think that could be needed.

Paladox added a comment.Oct 20 2016, 2:38 PM
In T147582#2731542, @Aklapper wrote:

@Paladox: My question was about your comment about "needing another security review". You did not answer why you think that could be needed.

Oh sorry I didn't know which part you wanted me to explain, anyways I was wondering if it needed to, to switch extension names, but never mind it doesn't sorry for wasting time.

Paladox mentioned this in rEPFMf637fda48480: Update Name of extension to PageForms.Oct 21 2016, 12:52 AM
Paladox mentioned this in rEPFM07777b03f9e8: Update Name of extension to PageForms.Oct 21 2016, 12:58 AM
Paladox mentioned this in rEPFMbea0d896368f: Update Name of extension to PageForms, DO NOT MERGE until this message is gone….Oct 21 2016, 10:59 AM
Paladox mentioned this in rEPFM6b0ddd61606c: Update Name of extension to PageForms, DO NOT MERGE until this message is gone….Oct 21 2016, 12:40 PM
Paladox mentioned this in rEPFM12bd90cd7a95: Update Name of extension to PageForms, DO NOT MERGE until this message is gone….Oct 21 2016, 1:49 PM
Paladox mentioned this in rEPFM4c0674288403: Update Name of extension to PageForms, DO NOT MERGE until this message is gone….Oct 21 2016, 2:14 PM
Paladox mentioned this in rEPFM68c08f0394e9: Update Name of extension to PageForms, DO NOT MERGE until this message is gone….Oct 21 2016, 8:05 PM
Paladox mentioned this in rEPFMacaa67f52e8b: Update Name of extension to PageForms.Oct 21 2016, 8:08 PM
gerritbot added a comment.Oct 21 2016, 8:30 PM

Change 316907 merged by Yaron Koren:
Update Name of extension to PageForms

https://gerrit.wikimedia.org/r/316907

gerritbot added a comment.Oct 21 2016, 8:39 PM

Change 317267 had a related patch set uploaded (by Paladox):
Fix some more renames

https://gerrit.wikimedia.org/r/317267

Paladox mentioned this in rEPFM2fa24d73bc0b: Fix some more renames.Oct 21 2016, 8:41 PM
gerritbot added a comment.Oct 21 2016, 8:42 PM

Change 317272 had a related patch set (by Paladox) published:
Add PageForms to translations list

https://gerrit.wikimedia.org/r/317272

Paladox mentioned this in rEPFMb263dd04b2b5: Fix some more renames.Oct 21 2016, 8:54 PM
Paladox mentioned this in rEPFM76a31bf6d603: Fix some more renames.Oct 21 2016, 8:58 PM
Paladox mentioned this in rEPFM36ab15cc8f03: Fix some more renames.
gerritbot added a comment.Oct 21 2016, 9:02 PM

Change 317267 merged by Yaron Koren:
Fix some more renames

https://gerrit.wikimedia.org/r/317267

gerritbot added a comment.Oct 21 2016, 9:41 PM

Change 317278 had a related patch set uploaded (by Paladox):
More rename fixes

https://gerrit.wikimedia.org/r/317278

Paladox mentioned this in rEPFM5459d20621ac: More rename fixes.Oct 21 2016, 9:42 PM
Stashbot subscribed.Oct 22 2016, 12:52 PM

Mentioned in SAL (#wikimedia-labs) [2016-10-22T12:52:18Z] <paladox> deploying https://gerrit.wikimedia.org/r/317315 T147582

gerritbot added a comment.Oct 23 2016, 1:22 AM

Change 317278 merged by Yaron Koren:
More rename fixes

https://gerrit.wikimedia.org/r/317278

gerritbot added a comment.Oct 23 2016, 10:10 AM

Change 317272 merged by jenkins-bot:
Add PageForms to translations list, Drop SemanticForms for translations

https://gerrit.wikimedia.org/r/317272

Paladox added a comment.Oct 23 2016, 10:25 AM

SemanticForms is now no longer being translated and instead PageForms is now :)

Yaron_Koren added a comment.Oct 23 2016, 12:23 PM

That's great!

Paladox added a comment.Oct 23 2016, 12:24 PM

We now need to test it to make sure nothing broke, then we need to update wmf usage to use the new extension and then switch all development to the new extension.

Yaron_Koren added a comment.Oct 23 2016, 12:40 PM

So - as far as you know, is the conversion now done already?

Paladox added a comment.Oct 23 2016, 12:40 PM

@Yaron_Koren I'm not sure what you mean?

Yaron_Koren added a comment.Oct 23 2016, 4:10 PM

Basically, I want to now if I should start looking into (and potentially modifying) the code, or if you're still planning to make any more changes to it.

Paladox added a comment.Oct 23 2016, 4:20 PM

@Yaron_Koren oh, yeh you can start modifying the code now, but if I find a change to make can I make the change please?

It wont interfear with your changes.

Yaron_Koren added a comment.Oct 23 2016, 4:26 PM

Okay, great. You are of course always welcome to make more changes! I just didn't want to have conflicting commits.

Paladox added a comment.Oct 23 2016, 4:27 PM

:)

Yaron_Koren added a comment.Oct 23 2016, 4:27 PM

Unrelated question: is the Page Forms code viewable on Diffusion? If so, what's the URL?

Paladox added a comment.Oct 23 2016, 4:28 PM

@Yaron_Koren hi here https://phabricator.wikimedia.org/diffusion/EPFM/

Yaron_Koren added a comment.Oct 23 2016, 5:01 PM

Okay, great. It's strange that it's not "EPAF" or "EPFO", but I'm guessing that wasn't your decision...

Paladox added a comment.Oct 23 2016, 5:04 PM

Yep not my decision, this is just a callsign.

gerritbot added a comment.Oct 23 2016, 6:48 PM

Change 317398 had a related patch set uploaded (by Paladox):
Rename i18n messages part 1

https://gerrit.wikimedia.org/r/317398

gerritbot added a comment.Oct 23 2016, 6:49 PM

Change 317398 merged by Paladox:
Rename i18n messages part 1

https://gerrit.wikimedia.org/r/317398

Paladox mentioned this in rEPFM64cd8c856882: Rename i18n messages part 1.Oct 23 2016, 6:49 PM
gerritbot added a comment.Oct 23 2016, 9:56 PM

Change 317448 had a related patch set uploaded (by Paladox):
Update i18n messages part 2

https://gerrit.wikimedia.org/r/317448

gerritbot added a comment.Oct 23 2016, 9:56 PM

Change 317448 merged by Paladox:
Update i18n messages part 2

https://gerrit.wikimedia.org/r/317448

Paladox mentioned this in rEPFM8e87e78be7b9: Update i18n messages part 2.Oct 23 2016, 9:57 PM
gerritbot added a comment.Oct 23 2016, 11:04 PM

Change 317449 had a related patch set uploaded (by Paladox):
Add PageForms mw extension as a submodule

https://gerrit.wikimedia.org/r/317449

gerritbot added a comment.Oct 24 2016, 12:20 PM

Change 317449 abandoned by Paladox:
Add PageForms mw extension as a submodule

https://gerrit.wikimedia.org/r/317449

gerritbot added a comment.Oct 24 2016, 12:31 PM

Change 316908 merged by jenkins-bot:
[PageForms] Adding jenkins tests

https://gerrit.wikimedia.org/r/316908

gerritbot added a comment.Oct 24 2016, 2:21 PM

Change 317506 had a related patch set uploaded (by Paladox):
Fix namespace configs and fix extension description

https://gerrit.wikimedia.org/r/317506

Paladox mentioned this in rEPFMfb2510627549: Fix namespace configs and fix extension description.Oct 24 2016, 2:22 PM
gerritbot added a comment.Oct 24 2016, 2:49 PM

Change 317516 had a related patch set uploaded (by Paladox):
Add PageForms as a wmf extension

https://gerrit.wikimedia.org/r/317516

Paladox added a comment.Oct 24 2016, 2:50 PM

@Yaron_Koren PageForms now has jenkins tests.

Ive also added PageForms to the wmf branching list here https://gerrit.wikimedia.org/r/317516

gerritbot added a comment.Oct 24 2016, 4:25 PM

Change 317534 had a related patch set uploaded (by Paladox):
Fix php tag

https://gerrit.wikimedia.org/r/317534

gerritbot added a comment.Oct 24 2016, 4:27 PM

Change 317534 merged by jenkins-bot:
Fix php tag

https://gerrit.wikimedia.org/r/317534

Paladox mentioned this in rEPFM389d6ba0014e: Fix php tag.Oct 24 2016, 4:28 PM
gerritbot added a comment.Oct 24 2016, 5:04 PM

Change 317506 merged by jenkins-bot:
Fix namespace configs and fix extension description

https://gerrit.wikimedia.org/r/317506

Paladox mentioned this in rEPFM6c85deccaf7c: Fix namespace configs and fix extension description.Oct 24 2016, 5:04 PM
gerritbot added a comment.Oct 24 2016, 5:06 PM

Change 317516 merged by jenkins-bot:
Add PageForms as a wmf extension

https://gerrit.wikimedia.org/r/317516

ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2016-11-01_(1.29.0-wmf.1)).Oct 25 2016, 6:00 PM
gerritbot added a comment.Nov 1 2016, 8:57 PM

Change 319131 had a related patch set (by Paladox) published:
Wikitech: Switching from using SemanticForms to PageForms extension

https://gerrit.wikimedia.org/r/319131

Paladox mentioned this in T149749: Wikitech: Switch over from using extension SemanticForms to PageForms.Nov 1 2016, 9:33 PM
Paladox added a subtask: T149749: Wikitech: Switch over from using extension SemanticForms to PageForms.
Dereckson mentioned this in T149869: Security review for PageForms.Nov 3 2016, 2:35 AM
Yaron_Koren added a comment.Nov 4 2016, 5:06 PM

I see one remaining issue with the move - the top link here:

https://phabricator.wikimedia.org/diffusion/EPFM/

...should be:

https://gerrit.wikimedia.org/r/p/mediawiki/extensions/PageForms

and not:

http://phabricator.wikimedia.org/diffusion/EPFM/extension-pageforms.git

Paladox added a comment.Nov 5 2016, 12:17 AM

@Yaron_Koren that's because the gerrit clone link is hidden by default because it is mirror

An admin will need to make the link visible.

• demon closed this task as Declined.Jan 6 2017, 4:14 AM
• demon subscribed.

We don't rename repositories, plus this already happened as a second repo entirely.

• demon closed subtask T149749: Wikitech: Switch over from using extension SemanticForms to PageForms as Declined.Mar 17 2017, 4:32 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits