NWE's 'Show preview' doesn't load in new modules based on added content, e.g. gallery/maps
Closed, ResolvedPublic8 Estimated Story Points
Actions

Description

Some modules are only loaded if the content requires it. If such content is added in your edit, the module won't be available when you do an async show preview from the save dialog.

Details

	Subject	Repo	Branch	Lines +/-
	Load modules for preview	mediawiki/extensions/VisualEditor	master	+61 -11

Customize query in gerrit

Related Objects

Mentioned In: T185284: Timeless WTE2017 preview has inconsistent styling
T162399: Parsoid doesn't add JS modules to <head> in its output
T139852: Expose `modules` and `jsconfigvars` from Parsoid's parse API when converting wikitext
Mentioned Here: T181657: Deprecate and remove Parsoid's body-only mode

Event Timeline

Esanders created this task.Oct 8 2016, 6:26 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 8 2016, 6:26 AM

Yeah... Since we use Parsoid instead of the MW parser for this, it might take a bit of guesswork based on what we get back. The MW api.php action=parse gives a list of the ResourceLoader modules used on the page - Parsoid doesn't.

@ssastry, would Parsoid consider implementing such a thing?

Jdforrester-WMF triaged this task as Medium priority.Oct 11 2016, 7:06 PM

Jdforrester-WMF moved this task from To Triage to TR1: Releases on the VisualEditor board.

Jdforrester-WMF set the point value for this task to 8.

Jdforrester-WMF added a project: Parsoid.

Jdforrester-WMF added a parent task: T142523: Provide a second version of a beta modern wikitext editor integrated into the visual editor.Oct 12 2016, 4:27 PM

TheDJ added a subtask: T139852: Expose `modules` and `jsconfigvars` from Parsoid's parse API when converting wikitext.Dec 16 2016, 9:51 AM

Jdforrester-WMF merged a task: T153981: Preview doesn't work correctly when invoking a Lua module with nowiki tags.Feb 28 2017, 8:22 PM

Jdforrester-WMF added a subscriber: • Whatamidoing-WMF.

Change 406770 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] Load modules for preview

https://gerrit.wikimedia.org/r/406770

gerritbot added a project: Patch-For-Review.Jan 29 2018, 10:00 PM

Esanders mentioned this in T139852: Expose `modules` and `jsconfigvars` from Parsoid's parse API when converting wikitext.Jan 30 2018, 4:30 PM

Change 406770 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Load modules for preview

https://gerrit.wikimedia.org/r/406770

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)).Jan 30 2018, 6:00 PM

In T147702#2704594, @AlexMonk-WMF wrote:

Yeah... Since we use Parsoid instead of the MW parser for this, it might take a bit of guesswork based on what we get back. The MW api.php action=parse gives a list of the ResourceLoader modules used on the page - Parsoid doesn't.

Sorry, lost track of this. But, Parsoid does generate the list of modules in the <head> tag but if VE requests content in body_only mode, then it will not see this info. One of the reasons we want to get rid of the body_only option ( T181657 )

Jdforrester-WMF closed this task as Resolved.Jan 30 2018, 7:01 PM

Jdforrester-WMF assigned this task to Esanders.

Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptJan 30 2018, 7:01 PM

Jdforrester-WMF removed a project: Patch-For-Review.Jan 30 2018, 8:02 PM

Dvorapa subscribed.Jan 30 2018, 8:08 PM

matmarex merged a task: T169331: Styles for babel box aren't loaded in preview of visual wikitext editor.Nov 5 2019, 8:44 PM

matmarex added subscribers: Kaartic, matmarex, • Elitre, Bencemac.

Esanders mentioned this in T162399: Parsoid doesn't add JS modules to <head> in its output.Aug 21 2020, 12:31 PM

alistair3149 mentioned this in T185284: Timeless WTE2017 preview has inconsistent styling.May 30 2021, 5:15 PM

Izno removed a parent task: T142523: Provide a second version of a beta modern wikitext editor integrated into the visual editor.Jun 2 2021, 8:46 PM

Izno removed a subtask: T139852: Expose `modules` and `jsconfigvars` from Parsoid's parse API when converting wikitext.Jun 2 2021, 8:49 PM