Page MenuHomePhabricator

Write tests for addWiki that block anything breaking it
Open, Needs TriagePublic

Description

I'm not sure it's ever worked on first attempt for each wiki for me.

We should make some integration tests that make it impossible to merge any code that breaks this script.

Event Timeline

We should probably rewrite it, it's a pile of 💩

Krenair renamed this task from addWiki keeps being broken by people to Write unit tests for addWiki that block anything breaking it.Aug 30 2018, 12:15 PM

Though there's been numerous other breakages that often don't make it into a phabricator ticket, the latest occurrence of this is T203154: addWiki.php is broken due to "Database selection is disallowed to enable reuse."

Krenair renamed this task from Write unit tests for addWiki that block anything breaking it to Write tests for addWiki that block anything breaking it.Aug 30 2018, 12:36 PM