Page MenuHomePhabricator
Create Task
Maniphest T147750

Make scripts handle empty commonsTrackerCategory gracefully
Closed, ResolvedPublic
Actions

Description

In T143573#2683223, @Lokal_Profil wrote:

! In T143573#2683218, @Lokal_Profil wrote:
If commonsTrackerCategory is missing the country was skipped sometimes but I'm unsure about the following:

  • images_of_monuments_without_id.py
  • unused_monument_images.py
  • missing_commonscat_links.py

While these are potential stability issues they shouldn't be a problem for Nigeria since each is skipped because of another empty parameter (unusedImagesPage, imagesWithoutIdPage and missingCommonscatPage [undocumented?])

So essentially make the below deal gracefully with an empty commonsTrackerCategory:

  • images_of_monuments_without_id.py
  • unused_monument_images.py
  • missing_commonscat_links.py

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Handle missing commonsTrackerCategory gracefullyLokal Profillabs/tools/heritagemaster+19 -2
Customize query in gerrit

Related Objects

Event Timeline

Lokal_Profil created this task.Oct 9 2016, 1:42 PM
Restricted Application added subscribers: JeanFred, • Aklapper. · View Herald TranscriptOct 9 2016, 1:42 PM
Lokal_Profil added a project: User-Lokal_Profil.Aug 23 2018, 10:18 PM
Lokal_Profil moved this task from 📥 Backlog to 🏖️ Non-WMSE on the User-Lokal_Profil board.
gerritbot subscribed.Aug 23 2018, 10:35 PM

Change 455023 had a related patch set uploaded (by Lokal Profil; owner: Lokal Profil):
[labs/tools/heritage@master] Handle missing commonsTrackerCategory gracefully

https://gerrit.wikimedia.org/r/455023

gerritbot added a project: Patch-For-Review.Aug 23 2018, 10:35 PM
gerritbot added a comment.Aug 24 2018, 5:19 PM

Change 455023 merged by jenkins-bot:
[labs/tools/heritage@master] Handle missing commonsTrackerCategory gracefully

https://gerrit.wikimedia.org/r/455023

Lokal_Profil edited projects, added: Wiki-Loves-Monuments; removed: Patch-For-Review, Wiki-Loves-Monuments-Database.Aug 27 2018, 10:21 AM
Lokal_Profil edited projects, added: Wiki-Loves-Monuments-Database, Wiki-Loves-Monuments (2018); removed: Wiki-Loves-Monuments.
Lokal_Profil moved this task from Backlog to Done - in August on the Wiki-Loves-Monuments (2018) board.
Effeietsanders closed this task as Resolved.Nov 18 2018, 1:36 AM
Effeietsanders claimed this task.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits