Page MenuHomePhabricator

MediaWiki code coverage no longer runs parser tests
Closed, InvalidPublic

Description

It uses to take almost 4 hours to generate and nowadays a bit less than 2 hours which is still a lot. Build time trend:

The huge drop from 220 minutes to 100 minutes is git lg 3d7e37edd08edd4504bff920cc0b0972917f5795..4a975b8099ee11b15421d03be02206935a8422f1 which contains the refactoring of parser tests. Potentially parser tests are no longer participating in the coverage.

Presumably the parser tests are no more running for the coverage job. Might not be a big deal.

Event Timeline

hashar created this task.Oct 10 2016, 8:24 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 10 2016, 8:24 AM
Krinkle renamed this task from MediaWiki code coverage no more run parser tests to MediaWiki code coverage no longer runs parser tests.Oct 10 2016, 10:51 PM
Krinkle updated the task description. (Show Details)
Krinkle added subscribers: aaron, tstarling, Krinkle.EditedOct 10 2016, 10:57 PM
@hashar wrote

The huge drop from 220 minutes to 100 minutes is git lg 3d7e37edd08edd4504bff920cc0b0972917f5795..4a975b8099ee11b15421d03be02206935a8422f1 which contains the refactoring of parser tests. Potentially parser tests are no longer participating in the coverage.

https://phabricator.wikimedia.org/diffusion/MW/history/master/;4a975b8099ee11b15421d03be02206935a8422f1

4a975b8099ee @aaron Merge "add IGNORE INDEX option to mysql database handler"
3979e37fcfa6 @tstarling parserTests.php: Fix exit status
6117fb244fc6 @tstarling Refactor parser tests
3d7e37edd08e @aaron Merge "Use memory job queue for unit tests"

The parser test refactor is known to have sped up PHPUnit execution by ~ 2x

rCICF2eabb59434d6: mediawiki: Merge parsertests job back into main phpunit job

Unless we know that code coverage runs actually started to skip parser tests somehow, maybe it just got faster and maybe that's all :)

Also, do parser tests even have covers tags?

Krinkle closed this task as Invalid.Mar 20 2017, 9:52 PM

I don't know about coverage, but both before and after the aforementioned changes, Parser tests are included. This task is invalid.

I guess I got confused because the parser tests have been made way faster. Thank you for the task cleanup.