"Transcluded templates" on action=info contains empty bullet when >50
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Sjoerddebruin
	Oct 10 2016, 10:36 AM

Description

The section "Transcluded templates" on action=info shows a empty bullet when the amount of templates is higher than 50 (example). The source code shows the following:

<li 0="This list may be incomplete."></li>

This looks like invalid HTML to me, the information should be displayed in a different form.

Details

	Subject	Repo	Branch	Lines +/-
	TemplatesOnThisPage: The second paramter in rawElement is attributes, not content	mediawiki/core	master	+2 -2

Customize query in gerrit

Event Timeline

Sjoerddebruin created this task.Oct 10 2016, 10:36 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 10 2016, 10:36 AM

Sjoerddebruin updated the task description. (Show Details)Oct 10 2016, 10:38 AM

Code:

https://github.com/wikimedia/mediawiki/blob/master/includes/actions/InfoAction.php#L629

I haven't found what's wrong there.

Change 315144 had a related patch set uploaded (by Ladsgroup):
The second paramter in rawElement is attributes, not content

https://gerrit.wikimedia.org/r/315144

gerritbot added a project: Patch-For-Review.Oct 10 2016, 6:38 PM

Change 315144 merged by jenkins-bot:
TemplatesOnThisPage: The second paramter in rawElement is attributes, not content

https://gerrit.wikimedia.org/r/315144

ReleaseTaggerBot added projects: MW-1.28-release (WMF-deploy-2016-10-11_(1.28.0-wmf.22)), MW-1.28-release-notes.Oct 11 2016, 4:00 AM

abian added a project: MediaWiki-Special-pages.Oct 11 2016, 10:40 AM

abian removed a project: MediaWiki-Special-pages.

Ladsgroup closed this task as Resolved.Oct 11 2016, 11:27 AM

Ladsgroup claimed this task.

Restricted Application added a project: User-Ladsgroup. · View Herald TranscriptOct 11 2016, 11:27 AM

Ladsgroup moved this task from Incoming to Done on the User-Ladsgroup board.Oct 11 2016, 11:28 AM

"Transcluded templates" on action=info contains empty bullet when >50Closed, ResolvedPublicActions

Description

Details

Event Timeline

"Transcluded templates" on action=info contains empty bullet when >50
Closed, ResolvedPublic
Actions