Page MenuHomePhabricator

GlobalRenameProgress: display status "failed" if the rename failed, instead of "in progress".
Closed, DeclinedPublic

Description

Possible follow-ups:

  • fix the underlying error
  • fixStuckGlobalRename.php should treat inprogress status as failed
  • the rename log channel should go somewhere
  • "https://meta.wikimedia.org/wiki/Special:CentralAuth/Neurax%C4%B1s doesn't display any message about a rename being in progress" - should that be changed? (there is some exception-handling code in Special:CentralAuth which did that, but that's not called anymore since CentralAuthUser stopped throwing exceptions on unattached accounts)

First three are done, I'll call this fixed. If someone feels strongly about the last, feel free to file a task and assign it to me.

Okay :) I'd say that, after some time, renames incorrectly displaying "in progress" as status, should display "failed", and failing data recorded in logstash so devs could easily check what caused the failure. Thanks!

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

There is no "soft" way for rename to fail; failures will be caused by an exception, DB error or similar. That is usually recorded in Logstash (when not, or without any useful information, as in the case of some HHVM errors, there is not much we can do about it), if not always easy to find. My plan for improving discoverability is T142313 (and then maybe adding a ScopedLoggerContext which will add some flag to the logstash data of exceptions happening within its scope).

As for changing "in progress" to "failed", TBH I don't think it's worth the effort. Renames getting stuck should be very rare once ddb5f69 is in production, and all a timer would do is replicate the current human behavior of "wait a few days then report a bug" which works well enough as it is.

Should this task be closed per Tgr's comment?