Page MenuHomePhabricator

Voter eligibility form is inconsistent in dates it suggests and uses
Closed, ResolvedPublic

Description

VoterEligibilityPage.php defines date fields in the form that populates the voter eligibility list automatically. The code defines the maximum allowed value for these fields to be yesterday. However, if you leave them blank and submit the form, the value that is populated for them (based on a blank input for an HTMLDateTimeField) will be today's date. If you submit the form at this stage, you will get a warning about the date being out of range.

This is inconsistent. Ideally, the default value for these fields should both "yesterday" because today's data (whether it is edit counts or registration dates) is always incomplete.

Event Timeline

Huji created this task.Oct 12 2016, 7:32 PM
Restricted Application added subscribers: TerraCodes, Aklapper. · View Herald TranscriptOct 12 2016, 7:32 PM
Huji claimed this task.Oct 12 2016, 7:32 PM
Huji triaged this task as Lowest priority.
Huji updated the task description. (Show Details)Oct 12 2016, 7:50 PM
Huji renamed this task from Vetereligibility populate form is inconsistent in dates it suggests and uses to Voter eligibility form is inconsistent in dates it suggests and uses.Oct 12 2016, 8:00 PM

Change 315558 had a related patch set uploaded (by Huji):
Voter eligibility form is inconsistent in dates it suggests and uses

https://gerrit.wikimedia.org/r/315558

Change 315558 merged by jenkins-bot:
Voter eligibility form is inconsistent in dates it suggests and uses

https://gerrit.wikimedia.org/r/315558

Huji closed this task as Resolved.Oct 13 2016, 12:45 AM