Page MenuHomePhabricator
Create Task
Maniphest T147993

mobile frontend log notice: Undefined property
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Notice: Undefined property: MobilePage::$revisionTimestamp in /srv/mediawiki/php-1.28.0-wmf.22/extensions/MobileFrontend/includes/models/MobilePage.php on line 66

Details

SubjectRepoBranchLines +/-
MobilePage: Fix undefined revisionTimestamp propertymediawiki/extensions/MobileFrontendwmf/1.28.0-wmf.22+4 -0
MobilePage: Fix undefined revisionTimestamp propertymediawiki/extensions/MobileFrontendmaster+4 -0
Customize query in gerrit

Related Objects

Event Timeline

Matanya created this task.Oct 13 2016, 12:26 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 13 2016, 12:26 AM
Matanya renamed this task from mobile frontend log notice to mobile frontend log notice: Undefined property.Oct 13 2016, 12:26 AM
Matanya added a project: Wikimedia-production-error.Oct 13 2016, 1:00 PM
• jhobs added a project: Web-Team-Backlog.Oct 13 2016, 5:14 PM
Jdlrobson added a subscriber: Krinkle.Oct 13 2016, 5:14 PM
ovasileva subscribed.Oct 13 2016, 8:16 PM
• jhobs subscribed.EditedOct 13 2016, 8:16 PM

@Matanya Can you elaborate the description with some reproduction steps and/or where you're seeing the notice? I'm guessing in the logs? Browser/OS information would be helpful as well.

• jhobs triaged this task as High priority.Oct 13 2016, 8:18 PM
• jhobs moved this task from Incoming to Needs Prioritization on the Web-Team-Backlog board.
Krenair subscribed.Oct 13 2016, 8:19 PM

I think all of matanya's log extracts come from logstash, but you should be able to find the same errors on fluorine

Matanya added a comment.Oct 14 2016, 7:53 AM

I go through logstash after deploys and try to find issues, before they blow. I saw this warning, and tought it would useful to report.

Krenair added a comment.Oct 14 2016, 9:29 AM

Yes, these need to be reported when found

Krinkle claimed this task.Oct 14 2016, 3:41 PM

Introduced by rEMFR09ece8aac123: MobilePage: Avoid uncached query for Last modified timestamp. Forgot to declare the property in the class.

Krinkle moved this task from Untriaged to Mar 2021 on the Wikimedia-production-error board.Oct 14 2016, 3:43 PM
gerritbot subscribed.Oct 14 2016, 3:43 PM

Change 315964 had a related patch set uploaded (by Krinkle):
MobilePage: Fix undefined revisionTimestamp property

https://gerrit.wikimedia.org/r/315964

gerritbot added a project: Patch-For-Review.Oct 14 2016, 3:43 PM
gerritbot added a comment.Oct 14 2016, 5:16 PM

Change 315964 merged by jenkins-bot:
MobilePage: Fix undefined revisionTimestamp property

https://gerrit.wikimedia.org/r/315964

ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-10-25_(1.28.0-wmf.23)).Oct 14 2016, 6:00 PM
Jdlrobson removed a project: Patch-For-Review.Oct 18 2016, 12:09 AM
Dereckson merged a task: T148545: Undefined property $revisionTimestamp in MobilePage::getLatestTimestamp.Oct 18 2016, 4:49 PM
Dereckson subscribed.
Dereckson added a comment.Oct 18 2016, 4:52 PM

Error still occurs in production (321 times in the last 1000 errors on fatalmonitor), a backport to wmf22 is welcome.

gerritbot added a comment.Oct 18 2016, 4:52 PM

Change 316585 had a related patch set uploaded (by Dereckson):
MobilePage: Fix undefined revisionTimestamp property

https://gerrit.wikimedia.org/r/316585

gerritbot added a project: Patch-For-Review.Oct 18 2016, 4:52 PM
gerritbot added a comment.Oct 18 2016, 6:12 PM

Change 316585 merged by jenkins-bot:
MobilePage: Fix undefined revisionTimestamp property

https://gerrit.wikimedia.org/r/316585

ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-10-11_(1.28.0-wmf.22)).Oct 18 2016, 7:00 PM
Dereckson closed this task as Resolved.EditedOct 18 2016, 11:11 PM

This change has been backported to 1.28.0-wmf.22 and deployed to the cluster.

Error occurences are decreasing in the logs.

23:15:25 < icinga-wm> RECOVERY - Esams HTTP 5xx reqs/min on graphite1001 is OK: OK: Less than 1.00% above the threshold [250.0]

• Phabricator_maintenance moved this task from Needs Prioritization to 2016-17 Q2 on the Web-Team-Backlog board.Mar 6 2018, 11:47 PM
• mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:11 PM
Krinkle moved this task from Mar 2021 to Untriaged on the Wikimedia-production-error board.Feb 10 2021, 7:25 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL