Page MenuHomePhabricator
Create Task
Maniphest T148118

Parsoid doesn't include the main image for a File page
Closed, ResolvedPublic
Actions

Description

https://en.wikipedia.org/api/rest_v1/page/html/File%3ARon_Rivera_(cropped).jpg does not show the main image the File page is about.
(It redirects to https://commons.wikimedia.org/api/rest_v1/page/html/File%3ARon_Rivera_(cropped).jpg. Not sure if that is pertinent here.)

pasted_file (782×869 px, 221 KB)

https://en.wikipedia.org/wiki/File:Ron_Rivera_(cropped).jpg shows an image.

pasted_file (708×873 px, 568 KB)

This is a followup task of T135242: [BUG] Image not shown for Content Service file pages, where the Android app added a workaround by not using Parsoid for File pages.

Details

SubjectRepoBranchLines +/-
Update: show image on image File pagesmarvinmaster+199 -5
Add additional information to file and user pages for renderingmediawiki/services/mobileappsmaster+114 -8
Customize query in gerrit

Related Objects
Search...

Event Timeline

• bearND created this task.Oct 14 2016, 5:51 AM
• bearND moved this task from Incoming to Tracking on the Mobile-Content-Service board.
Dbrant moved this task from Needs Triage to Tracking on the Wikipedia-Android-App-Backlog board.Oct 14 2016, 12:55 PM
• GWicke added a subscriber: • GWicke.Oct 14 2016, 2:29 PM

I think there are good reasons for keeping the skin responsible for composing special pages like those for images. This keeps things flexible, and avoids mixing actual user-controlled content (image description) with auto-generated content (image itself, category trees etc).

That said, we could provide a default, "skinned" view for such pages that works for most use cases.

Jdlrobson added a subscriber: Jdlrobson.Oct 31 2016, 4:40 PM

@GWicke I'm not sure I follow. The skin cannot be responsible when the page is formatted like so - the image url doesn't appear to be anywhere.

Any reason we cannot provide an array of urls for the different resolutions?

• GWicke added a comment.EditedOct 31 2016, 4:55 PM

@Jdlrobson, I'm not at all opposed to setting up a nice API exposing the metadata needed to render such a page in the skin, or even provide a basic default rendering. To avoid providing a limited list of resolutions, we have been looking into a proper thumb & image info API that lets clients select resolutions in T66214.

My point is that Parsoid shouldn't be in the business of implementing random skin functionality, like rendering image pages, special pages, or category pages.

Jdlrobson added a comment.Oct 31 2016, 4:57 PM

So @bearND it sounds like the MCS might want to do a fetch to mwApi and enrich the response with that information.

• bearND mentioned this in T120238: Wrong display of certain English Wikipedia portal pages in mobile.Nov 15 2016, 11:05 PM
• bearND added a comment.Nov 15 2016, 11:09 PM

@Jdlrobson Good idea. I'll move it to the backlog.

• bearND moved this task from Tracking to Backlog on the Mobile-Content-Service board.Nov 16 2016, 4:05 AM
Arlolra moved this task from Needs Triage to Non-Parsing-Team Tasks on the Parsoid board.Nov 24 2016, 2:27 AM
gerritbot added a comment.Dec 9 2016, 9:37 PM

Change 326178 had a related patch set uploaded (by Jdlrobson):
Add additional information to file and user pages for rendering

https://gerrit.wikimedia.org/r/326178

gerritbot added a project: Patch-For-Review.Dec 9 2016, 9:37 PM
gerritbot added a comment.Dec 15 2016, 10:21 PM

Change 326178 merged by jenkins-bot:
Add additional information to file and user pages for rendering

https://gerrit.wikimedia.org/r/326178

• bearND moved this task from Backlog to To Deploy on the Mobile-Content-Service board.Dec 20 2016, 6:40 PM
• bearND mentioned this in T153801: File and global user pages should not be redirected.Dec 20 2016, 10:15 PM
Arlolra mentioned this in T151223: Category listing pages are not populated properly in Parsoid.Dec 22 2016, 7:36 PM
• bearND closed this task as Resolved.Jan 4 2017, 9:34 PM
• bearND claimed this task.

deploy/2017-01-04/c39bd1f

• Fjalapeno mentioned this in T172550: Detect when pages have generated content, and figure out how to inject this content into the Read HTML.Aug 4 2017, 5:41 PM
• Niedzielski mentioned this in T176958: Display article content within article namespace.Nov 1 2017, 3:16 PM
• Niedzielski mentioned this in T179829: Add images to File pages.Nov 6 2017, 2:37 PM
gerritbot added a comment.Nov 17 2017, 5:21 PM

Change 392078 had a related patch set uploaded (by Niedzielski; owner: Sniedzielski):
[marvin@master] Update: show image on image File pages

https://gerrit.wikimedia.org/r/392078

Restricted Application added a project: Product-Infrastructure-Team-Backlog-Deprecated. · View Herald TranscriptNov 17 2017, 5:21 PM
• Niedzielski mentioned this in rMARV875ca448c7e6: Update: show image on image File pages.Nov 17 2017, 5:22 PM
• Niedzielski mentioned this in rMARV4d2236fa32b9: Update: show image on image File pages.Nov 20 2017, 4:55 PM
• Niedzielski mentioned this in rMARVa36fc1317f14: Update: show image on image File pages.Nov 20 2017, 6:49 PM
• Niedzielski mentioned this in rMARVed687f314058: Update: show image on image File pages.Nov 21 2017, 4:13 AM
• Niedzielski mentioned this in rMARVb9ee3c393511: Update: show image on image File pages.Nov 21 2017, 4:56 PM
gerritbot added a comment.Nov 21 2017, 4:57 PM

Change 392078 merged by jenkins-bot:
[marvin@master] Update: show image on image File pages

https://gerrit.wikimedia.org/r/392078

pmiazga mentioned this in T183985: Chromium-PDF cannot render articles from File namespace properly.Jan 2 2018, 8:06 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL