Page MenuHomePhabricator
Create Task
Maniphest T148193

Feature flag font-changer
Closed, ResolvedPublic2 Estimated Story Points
Actions

Assigned To
ovasileva
Authored By
• bmansurov
Oct 14 2016, 4:10 PM
Tags
Referenced Files
F5218309: T148193 iOS Safari Font Size Increase After Beta Mode.PNG
Jan 2 2017, 8:18 PM
F5218286: T148193 Android Chrome on Before Beta Mode.png
Jan 2 2017, 8:18 PM
F5218307: T148193 iOS Safari No Font Size Option Before Beta Mode.PNG
Jan 2 2017, 8:18 PM
F5218305: T148193 iOS Firefox Font Size Increase After Beta Mode.PNG
Jan 2 2017, 8:18 PM
F5218299: T148193 iOS Firefox Font Size Increase After Beta Mode.PNG
Jan 2 2017, 8:18 PM
F5218288: T148193 Android Chrome Font Size Increase After Beta Mode.png
Jan 2 2017, 8:18 PM
F5218292: T148193 Android Internet Font Size Increase After Beta Mode.png
Jan 2 2017, 8:18 PM
F5218297: T148193 iOS Firefox No Font Size Option Before Beta Mode.PNG
Jan 2 2017, 8:18 PM
View All 11 Files
Subscribers
Aklapper
• bmansurov
gerritbot
Jdlrobson
• Jhernandez
• jhobs
Nicholas.tsg
View All 9 Subscribers

Description

As part of removing SkinMinervaBeta, we should feature flag the font-changer code.

Test Plan

Screen Shot 2016-12-21 at 3.41.30 PM.png (294×1 px, 26 KB)

  • Opt into the beta mode and go back to the settings page.
  • Verify that you see an option to change the font size.
  • Increase (or decrease) the font size and go to some page (e.g. Main page) and verify that the site font size has indeed changed.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Hygiene: Tidy SpecialMobileOptions module listingmediawiki/extensions/MobileFrontendmaster+25 -7
Special:MobileOptions: don't load font changer module unconditionallymediawiki/extensions/MobileFrontendmaster+30 -12
Extract checkbox from an init modulemediawiki/extensions/MobileFrontendmaster+49 -35
Feature flag FontChangermediawiki/extensions/MobileFrontendmaster+52 -16
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedJdlrobsonT147944 [EPIC] Remove SkinMinervaBeta class
 ResolvedovasilevaT148193 Feature flag font-changer

Event Timeline

• bmansurov created this task.Oct 14 2016, 4:10 PM
Restricted Application removed a project: Patch-For-Review. · View Herald TranscriptOct 14 2016, 4:10 PM
• bmansurov removed a project: Epic.Oct 14 2016, 4:24 PM
• bmansurov moved this task from Uncategorized to Clean-Up on the Technical-Debt (RW-Tech-Debt) board.Oct 14 2016, 4:26 PM
ovasileva moved this task from Incoming to Triaged but Future on the Web-Team-Backlog-Archived board.Oct 20 2016, 7:49 PM
• bmansurov mentioned this in T148199: [Spike: 1hr] Identify differences between SkinMinervaBeta and SkinMinerva.Nov 23 2016, 11:27 PM
gerritbot added a comment.Dec 12 2016, 10:57 PM

Change 326839 had a related patch set uploaded (by Bmansurov):
Feature flag FontChanger

https://gerrit.wikimedia.org/r/326839

gerritbot added a project: Patch-For-Review.Dec 12 2016, 10:57 PM
• bmansurov mentioned this in T147944: [EPIC] Remove SkinMinervaBeta class.Dec 12 2016, 11:15 PM
• bmansurov added projects: Reading-Web-Sprint-87-♨️😭, Unplanned-Sprint-Work.Dec 14 2016, 1:54 PM
ovasileva set the point value for this task to 2.Dec 14 2016, 6:14 PM
ovasileva moved this task from Needs Analysis to Needs More Work on the Reading-Web-Sprint-87-♨️😭 board.
• bmansurov claimed this task.Dec 14 2016, 6:31 PM
• bmansurov moved this task from Needs More Work to Code Review on the Reading-Web-Sprint-87-♨️😭 board.Dec 15 2016, 9:27 PM
gerritbot added a comment.Dec 16 2016, 8:27 PM

Change 326839 merged by jenkins-bot:
Feature flag FontChanger

https://gerrit.wikimedia.org/r/326839

Jdlrobson moved this task from Code Review to Ready for Signoff on the Reading-Web-Sprint-87-♨️😭 board.Dec 16 2016, 8:32 PM
ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2017-01-03_(1.29.0-wmf.7)).Dec 16 2016, 9:00 PM
• bmansurov added subscribers: pmiazga, • Jhernandez.Dec 16 2016, 9:13 PM

@phuedx, @pmiazga, @Jhernandez can one of you please sign off?

MBinder_WMF reassigned this task from • bmansurov to pmiazga.Dec 19 2016, 5:08 PM
MBinder_WMF added a project: Reading-Web-Sprint-88-¯\_(ツ)_/¯.
MBinder_WMF moved this task from Needs Analysis to Ready for Signoff on the Reading-Web-Sprint-88-¯\_(ツ)_/¯ board.Dec 19 2016, 5:20 PM
MBinder_WMF removed a project: Unplanned-Sprint-Work.Dec 19 2016, 5:21 PM
pmiazga moved this task from Ready for Signoff to Needs More Work on the Reading-Web-Sprint-88-¯\_(ツ)_/¯ board.Dec 19 2016, 10:30 PM
pmiazga added a comment.Dec 19 2016, 10:36 PM

Moved back to "Needs more work" as Font switcher option on Special:MobileOptions is alway visible, even FontChanger is disabled.
Reason: When rendering MobileOptions we show FontChanger for all beta members - corresponding code: https://github.com/wikimedia/mediawiki-extensions-MobileFrontend/blob/master/resources/mobile.special.mobileoptions.scripts/mobileoptions.js#L44.

Because of that even we disable FontChanger the settings will still appear.

pmiazga reassigned this task from pmiazga to • bmansurov.Dec 19 2016, 10:40 PM
• bmansurov moved this task from Needs More Work to Doing on the Reading-Web-Sprint-88-¯\_(ツ)_/¯ board.Dec 19 2016, 11:15 PM
gerritbot added a comment.Dec 20 2016, 12:39 AM

Change 328314 had a related patch set uploaded (by Bmansurov):
Extract checkbox from an init module

https://gerrit.wikimedia.org/r/328314

gerritbot added a comment.Dec 20 2016, 1:19 AM

Change 328318 had a related patch set uploaded (by Bmansurov):
Special:MobileOptions: don't load font changer module unconditionally

https://gerrit.wikimedia.org/r/328318

gerritbot added a comment.Dec 20 2016, 1:19 AM

Change 328314 abandoned by Bmansurov:
Extract checkbox from an init module

Reason:
not needed for now

https://gerrit.wikimedia.org/r/328314

• bmansurov moved this task from Doing to Code Review on the Reading-Web-Sprint-88-¯\_(ツ)_/¯ board.Dec 21 2016, 12:05 AM
gerritbot added a comment.Dec 21 2016, 8:08 AM

Change 328318 merged by jenkins-bot:
Special:MobileOptions: don't load font changer module unconditionally

https://gerrit.wikimedia.org/r/328318

gerritbot added a comment.Dec 21 2016, 10:33 AM

Change 328485 had a related patch set uploaded (by Phuedx):
Hygiene: Tidy SpecialMobileOptions module listing

https://gerrit.wikimedia.org/r/328485

phuedx added a comment.Dec 21 2016, 10:34 AM

I've tested @bmansurov's changes locally and can verify it works as expected. My change tidies up the code just a little.

ovasileva moved this task from Triaged but Future to 2016-17 Q2 on the Web-Team-Backlog-Archived board.Dec 21 2016, 5:01 PM
gerritbot added a comment.Dec 21 2016, 8:30 PM

Change 328485 merged by jenkins-bot:
Hygiene: Tidy SpecialMobileOptions module listing

https://gerrit.wikimedia.org/r/328485

• bmansurov moved this task from Code Review to Needs QA on the Reading-Web-Sprint-88-¯\_(ツ)_/¯ board.Dec 21 2016, 8:40 PM
• bmansurov reassigned this task from • bmansurov to Nicholas.tsg.Dec 21 2016, 8:43 PM
• bmansurov updated the task description. (Show Details)
Nicholas.tsg added a comment.Jan 2 2017, 8:18 PM

Testing devices:
Samsung-SM-J120A Galaxy Express 3 (Android 6.0.1)
iPhone 6s (iOS 10.1.1)

This looks fixed according to the following screencaps:

Android 6.0.1 with Chrome before Beta mode

T148193 Android Chrome on Before Beta Mode.png (800×480 px, 57 KB)
after Beta mode
T148193 Android Chrome Font Size Increase After Beta Mode.png (800×480 px, 64 KB)

Android 6.0.1 with Internet browser before Beta mode
T148193 Android Internet No Font Size Option Before Beta Mode.png (800×480 px, 38 KB)
after Beta mode
T148193 Android Internet Font Size Increase After Beta Mode.png (800×480 px, 41 KB)

iOS 10.1.1 with Firefox before Beta mode
T148193 iOS Firefox No Font Size Option Before Beta Mode.PNG (1×750 px, 99 KB)
after Beta mode
T148193 iOS Firefox Font Size Increase After Beta Mode.PNG (1×750 px, 130 KB)

iOS 10.1.1 with Chrome before Beta mode
T148193 iOS Firefox No Font Size Option Before Beta Mode.PNG (1×750 px, 99 KB)
after Beta mode
T148193 iOS Firefox Font Size Increase After Beta Mode.PNG (1×750 px, 130 KB)

iOS 10.1.1 with Safari before Beta mode
T148193 iOS Safari No Font Size Option Before Beta Mode.PNG (1×750 px, 167 KB)
after Beta mode
T148193 iOS Safari Font Size Increase After Beta Mode.PNG (1×750 px, 199 KB)

Nicholas.tsg moved this task from Needs QA to Ready for Signoff on the Reading-Web-Sprint-88-¯\_(ツ)_/¯ board.Jan 2 2017, 8:18 PM
• bmansurov reassigned this task from Nicholas.tsg to ovasileva.Jan 3 2017, 4:01 PM
• bmansurov added a subscriber: Nicholas.tsg.
ovasileva closed this task as Resolved.Jan 3 2017, 4:06 PM

all done!

• Phabricator_maintenance moved this task from 2016-17 Q2 to 2016-17 Q3 on the Web-Team-Backlog-Archived board.Mar 6 2018, 11:39 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits