In order to remove SkinMinervaBeta, remove the donation link feature (per T148196#2747933)
Description
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Remove the donation link feature from Minerva Beta skin | mediawiki/extensions/MobileFrontend | master | +2 -22 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Jdlrobson | T147944 [EPIC] Remove SkinMinervaBeta class | |||
| Resolved | phuedx | T148196 Remove the donation link feature |
Event Timeline
FYI, given it's not used we could also remove this. @awight are there any plans to make use of this configuration variable for any A/B tests to show a donation link in the mobile UI?
@pmiazga will you remove or feature flag it?
I would prefer we remove this given it is not being used, but I guess that's @ovasileva 's call.
not sure yet, first I wanted to check the code and then speak with you @Jdlrobson and @awight about next steps because currently I don't know what is the best way to do it (remove vs feature flag it).
@pmiazga if you end up removing it, then please update the task title and description as such.
@Pcoombe or @MeganHernandez_WMF , do either of you know about this mobile skin donation link feature? Since there's no sidebar on mobile, I'm guessing this link would show up in the footer if it was ever activated. Think it's OK to remove?
@Ejegg I should clarify:
There is a config variable $wgMFDonationUrl which can be false or a string.
If set to a string, a "Donate" button will appear at the bottom of the mobile interface for users in the mobile beta mode that links to this URL.
The URL cannot be customised in anyway. e.g. you can't pass the page title to the url.
The question is does the fundraising team have any plans on using this in the short term future?
Has this ever been enabled? If not, then I don't see a problem removing it. We may want to revisit adding a link at some point in the future, although my guess is the best place would be the sidebar menu.
@pmiazga - sounds like there's no immediate plans on using it. Let's go ahead and remove it.
@Pcoombe nope it's never been enabled. I think there were plans a couple of years ago but they sadly never came to fruition (hence there is still no donate link on the mobile site)
Change 318980 had a related patch set uploaded (by Pmiazga):
Remove the donation link feature from Minerva Beta skin
Change 318980 merged by jenkins-bot:
Remove the donation link feature from Minerva Beta skin
rEMFR729c3f523806: Remove the donation link feature from Minerva Beta skin LGTM as does the secondary actions bar on Claude Monet on the Beta Cluster, for example.