Page MenuHomePhabricator

Remove the donation link feature
Closed, ResolvedPublic2 Story Points

Description

In order to remove SkinMinervaBeta, remove the donation link feature (per T148196#2747933)

Event Timeline

Restricted Application removed a project: Patch-For-Review. · View Herald TranscriptOct 14 2016, 4:17 PM
bmansurov moved this task from Uncategorized to Clean-Up on the Technical-Debt (RW-Tech-Debt) board.
ovasileva set the point value for this task to 2.

FYI, given it's not used we could also remove this. @awight are there any plans to make use of this configuration variable for any A/B tests to show a donation link in the mobile UI?

pmiazga claimed this task.Oct 25 2016, 5:32 PM
pmiazga added a subscriber: pmiazga.

I'll try to tackle this one

Jdlrobson added a subscriber: ovasileva.

@pmiazga will you remove or feature flag it?
I would prefer we remove this given it is not being used, but I guess that's @ovasileva 's call.

If we're not using it, I think it's okay to remove.

not sure yet, first I wanted to check the code and then speak with you @Jdlrobson and @awight about next steps because currently I don't know what is the best way to do it (remove vs feature flag it).

@pmiazga if you end up removing it, then please update the task title and description as such.

Yes, on second though, let's wait to hear from @awight first

@Pcoombe or @MeganHernandez_WMF , do either of you know about this mobile skin donation link feature? Since there's no sidebar on mobile, I'm guessing this link would show up in the footer if it was ever activated. Think it's OK to remove?

@Ejegg I should clarify:
There is a config variable $wgMFDonationUrl which can be false or a string.
If set to a string, a "Donate" button will appear at the bottom of the mobile interface for users in the mobile beta mode that links to this URL.

The URL cannot be customised in anyway. e.g. you can't pass the page title to the url.

The question is does the fundraising team have any plans on using this in the short term future?

Has this ever been enabled? If not, then I don't see a problem removing it. We may want to revisit adding a link at some point in the future, although my guess is the best place would be the sidebar menu.

@pmiazga - sounds like there's no immediate plans on using it. Let's go ahead and remove it.

@Pcoombe nope it's never been enabled. I think there were plans a couple of years ago but they sadly never came to fruition (hence there is still no donate link on the mobile site)

Change 318980 had a related patch set uploaded (by Pmiazga):
Remove the donation link feature from Minerva Beta skin

https://gerrit.wikimedia.org/r/318980

bmansurov updated the task description. (Show Details)Oct 31 2016, 9:33 PM
bmansurov added a subscriber: Jhernandez.

@Jdlrobson @Jhernandez @jhobs @phuedx can one of you please sign off? Thanks.

bmansurov renamed this task from Feature flag donation link to Remove the donation link feature.Oct 31 2016, 9:36 PM

Change 318980 merged by jenkins-bot:
Remove the donation link feature from Minerva Beta skin

https://gerrit.wikimedia.org/r/318980

phuedx claimed this task.Nov 1 2016, 9:53 AM