Page MenuHomePhabricator
Create Task
Maniphest T148203

Add error handling to description editing interface.
Closed, ResolvedPublic0.5 Estimated Story Points
Actions

Assigned To
• Niedzielski
Authored By
Dbrant
Oct 14 2016, 4:49 PM
Tags
Referenced Files
F5214791: T148203.png
Jan 1 2017, 8:26 PM
F5041489: hammerheadM4B30Xrho12122016174001.gif
Dec 12 2016, 4:40 PM
F4879372: screenshot-2016-11-28-16-11-59-041276575.png
Nov 28 2016, 11:17 PM
F4879369: screenshot-2016-11-28-16-11-53-718590551.png
Nov 28 2016, 11:17 PM
F4878286: pasted_file
Nov 28 2016, 8:39 PM
F4819433: screenshot-2016-11-21-12-46-24-808815886.png
Nov 21 2016, 7:47 PM
F4743201: pasted_file
Nov 18 2016, 7:33 PM
Subscribers
Aklapper
Dbrant
gerritbot
Nicholas.tsg
RHo
• Sniedzielski

Description

This is to create a visual component that shows error information received from the server when the description is rejected (AbuseFilter, or other type of error).

  • The component will be shown inline with the editing interface (i.e. below the edit field).
  • The component will appear only when an error condition was returned by the server.

Details

SubjectRepoBranchLines +/-
Update: hide description length on error, show on editapps/android/wikipediamaster+9 -70
Add error feedback UI to description editingapps/android/wikipediamaster+47 -22
Hygiene: add layout prefixes to description IDsapps/android/wikipediamaster+18 -24
Fix potential NPE & hygiene in DescriptionEditViewapps/android/wikipediamaster+35 -29
Add DescriptionEditViewTestapps/android/wikipediamaster+133 -4
Hygiene: replace requestFocus idiom with utilapps/android/wikipediamaster+15 -27
Add @TestedOnBool annotation for @Theory testsapps/android/wikipediamaster+29 -0
Marshal DescriptionEditFragment Bundle not Intentapps/android/wikipediamaster+13 -7
Customize query in gerrit

Event Timeline

Dbrant created this task.Oct 14 2016, 4:49 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 14 2016, 4:49 PM
MBinder_WMF added a project: Mobile-App-Android-Sprint-94-Plutonium.Oct 14 2016, 6:30 PM
MBinder_WMF set the point value for this task to 0.5.Oct 14 2016, 6:34 PM
Dbrant moved this task from Needs Triage to Product Backlog on the Wikipedia-Android-App-Backlog board.Oct 17 2016, 6:10 PM
• Niedzielski claimed this task.Nov 3 2016, 10:16 PM
• Niedzielski moved this task from To Do to Doing on the Mobile-App-Android-Sprint-94-Plutonium board.
gerritbot subscribed.Nov 3 2016, 11:07 PM

Change 319760 had a related patch set uploaded (by Niedzielski):
Marshal DescriptionEditFragment Bundle not Intent

https://gerrit.wikimedia.org/r/319760

gerritbot added a project: Patch-For-Review.Nov 3 2016, 11:07 PM
MBinder_WMF added a project: Mobile-App-Android-Sprint-95-Americium.Nov 4 2016, 6:18 PM
• Niedzielski moved this task from To Do to Doing on the Mobile-App-Android-Sprint-95-Americium board.Nov 4 2016, 6:18 PM
gerritbot added a comment.Nov 4 2016, 7:15 PM

Change 319760 merged by jenkins-bot:
Marshal DescriptionEditFragment Bundle not Intent

https://gerrit.wikimedia.org/r/319760

gerritbot added a comment.Nov 4 2016, 9:08 PM

Change 319917 had a related patch set uploaded (by Niedzielski):
Add @TestedOnBool annotation for @Theory tests

https://gerrit.wikimedia.org/r/319917

gerritbot added a comment.Nov 4 2016, 9:08 PM

Change 319918 had a related patch set uploaded (by Niedzielski):
Hygiene: replace requestFocus idiom with util

https://gerrit.wikimedia.org/r/319918

gerritbot added a comment.Nov 4 2016, 9:08 PM

Change 319919 had a related patch set uploaded (by Niedzielski):
Add DescriptionEditViewTest

https://gerrit.wikimedia.org/r/319919

gerritbot added a comment.Nov 7 2016, 11:40 PM

Change 320311 had a related patch set uploaded (by Niedzielski):
Fix potential NPE & hygiene in DescriptionEditView

https://gerrit.wikimedia.org/r/320311

gerritbot added a comment.Nov 7 2016, 11:40 PM

Change 320313 had a related patch set uploaded (by Niedzielski):
Hygiene: add layout prefixes to description IDs

https://gerrit.wikimedia.org/r/320313

gerritbot added a comment.Nov 8 2016, 6:36 PM

Change 319917 merged by jenkins-bot:
Add @TestedOnBool annotation for @Theory tests

https://gerrit.wikimedia.org/r/319917

gerritbot added a comment.Nov 8 2016, 8:27 PM

Change 319918 merged by jenkins-bot:
Hygiene: replace requestFocus idiom with util

https://gerrit.wikimedia.org/r/319918

gerritbot added a comment.Nov 8 2016, 8:35 PM

Change 319919 merged by jenkins-bot:
Add DescriptionEditViewTest

https://gerrit.wikimedia.org/r/319919

gerritbot added a comment.Nov 8 2016, 9:26 PM

Change 320311 merged by jenkins-bot:
Fix potential NPE & hygiene in DescriptionEditView

https://gerrit.wikimedia.org/r/320311

gerritbot added a comment.Nov 8 2016, 9:54 PM

Change 320313 merged by jenkins-bot:
Hygiene: add layout prefixes to description IDs

https://gerrit.wikimedia.org/r/320313

gerritbot added a comment.Nov 8 2016, 11:53 PM

Change 320543 had a related patch set uploaded (by Niedzielski):
Add error feedback UI to description editing

https://gerrit.wikimedia.org/r/320543

• Niedzielski moved this task from Doing to Code Review on the Mobile-App-Android-Sprint-95-Americium board.Nov 8 2016, 11:54 PM
gerritbot added a comment.Nov 15 2016, 3:12 PM

Change 320543 merged by jenkins-bot:
Add error feedback UI to description editing

https://gerrit.wikimedia.org/r/320543

• bearND moved this task from Code Review to Design Signoff on the Mobile-App-Android-Sprint-95-Americium board.Nov 16 2016, 6:25 AM
MBinder_WMF edited projects, added Wikipedia-Android-App-Backlog (Android-app-release-v2.6.19x-Bermuda🌴); removed Wikipedia-Android-App-Backlog.Nov 18 2016, 7:07 PM
MBinder_WMF moved this task from To Do to Design Signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.6.19x-Bermuda🌴) board.Nov 18 2016, 7:11 PM
RHo subscribed.Nov 18 2016, 7:33 PM

hi @Niedzielski – I'm unable to see any error messaging on the latest alpha. The linear progress indicator is just animating in a loop with no message at all to design review. Am I missing a trick?

pasted_file (1×1 px, 92 KB)

• Niedzielski added a comment.Nov 21 2016, 7:47 PM

@RHo, you should see something like this (I just flipped on airplane mode and pressed submit):

screenshot-2016-11-21-12-46-24-808815886.png (2×1 px, 204 KB)

RHo added a comment.Nov 28 2016, 8:39 PM

hi @Niedzielski – can we fix this so the error message doesn't push down the counter?

Expected:

pasted_file (266×832 px, 37 KB)

(screenshot from the demo component on the Angular material site)

Secondly, I will file a separate ticket since I think we should display system errors (such as no connectivity) as toasts/snackbar rather than inline validation, since the error has nothing to do with the input itself.

gerritbot added a comment.Nov 28 2016, 11:17 PM

Change 323987 had a related patch set uploaded (by Niedzielski):
Update: hide description length on error, show on edit

https://gerrit.wikimedia.org/r/323987

• Niedzielski added a comment.Nov 28 2016, 11:17 PM

@RHo, it looks like we were using a custom view for this when we should have been using the built in platform components from Google. I've refactored this view and now the counter fades out on error and back in when editing. Does this work for you?

screenshot-2016-11-28-16-11-53-718590551.png (2×1 px, 170 KB)
screenshot-2016-11-28-16-11-59-041276575.png (2×1 px, 183 KB)

RHo added a subscriber: • Sniedzielski.Nov 29 2016, 9:17 PM

@Sniedzielski - yep this works as a good compromise.

gerritbot added a comment.Dec 8 2016, 2:29 PM

Change 323987 merged by jenkins-bot:
Update: hide description length on error, show on edit

https://gerrit.wikimedia.org/r/323987

RHo moved this task from Design Signoff to QA Signoff on the Mobile-App-Android-Sprint-95-Americium board.Dec 12 2016, 4:40 PM

LGTM

hammerheadM4B30Xrho12122016174001.gif (960×540 px, 380 KB)

RHo moved this task from Design Signoff to QA Signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.6.19x-Bermuda🌴) board.Dec 12 2016, 4:41 PM
Nicholas.tsg subscribed.Dec 13 2016, 11:39 PM

Hi, could someone please write Steps to reproduce/Expected Results/Actual Results so I can reproduce the scenario using an Android Handset? Thanks.

• Niedzielski added a comment.Dec 15 2016, 10:42 PM

o/ @Nicholas.tsg

  1. Go to the Wikipedia:Wikidata/Wikidata Sandbox page
  2. Edit the description by tapping the first pencil
  3. Put the device in airplane mode
  4. Change the description and submit
Nicholas.tsg added a comment.Jan 1 2017, 8:26 PM

Testing specs: Samsung-SM-J120A, Android version 6.0.1, Wikipedia app build 2.4.184-alpha-2016-12-23. This is working as expected as error information is shown:

T148203.png (800×480 px, 65 KB)

Nicholas.tsg moved this task from QA Signoff to Ready for Signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.6.19x-Bermuda🌴) board.Jan 1 2017, 8:26 PM
Dbrant moved this task from Ready for Signoff to Done on the Wikipedia-Android-App-Backlog (Android-app-release-v2.6.19x-Bermuda🌴) board.Jan 3 2017, 9:34 PM
Dbrant closed this task as Resolved.Jan 12 2017, 3:31 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL