Change reference objects to use standard JavaScript prototypal inheritance. Use methods attached to the prototype, rather than every object. It currently uses this style (attaching to each object), which we should switch away from:
this.getIcon = function () {We should use OOjs for this (not OOjs UI yet, though).
The idea is that prototypal inheritance, e.g.:
proveit.Reference.prototype.foo = function ( bar ) {(as used in OOjs and other JS code bases) may be more understandable (especially to JS developers just starting with the ProveIt code base), standard, and maintainable. I recall I ran into one or two code issues due to this kind of inheritance, but I don't recall the exact details.