Maniphest T148235

Bad template names
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Sophivorus
	Oct 14 2016, 7:13 PM

Tags

Referenced Files

None

Subscribers

Description

If we have two templates, for example a normal "Template:Cite web" and a strange "Template:Cite web:Strange name" (Книга and Книга:Биологический энциклопедический словарь) then ProveIt will think that the template is "Cite web" rather than "Cite web:Strange name".

It seems that with certain template names, the gadget fails to scan them correctly. This is probably due to the extra colon, but it may also be a regex issue or encoding issue.

Details

	Subject	Repo	Branch	Lines +/-
	Match more specific templates first	wikipedia/gadgets/ProveIt	master	+7 -4

Customize query in gerrit

Related Objects

Mentioned In: rWGPI2b88b9a19d83: Match more specific templates first
rWGPI33b9c8f7fd2c: Match more specific templates first
rWGPI80cb19e63dea: Match specific subtemplate before general templates
rWGPI27e9111c6903: Support for nested templates

Event Timeline

Sophivorus created this task.Oct 14 2016, 7:13 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 14 2016, 7:13 PM

Sophivorus triaged this task as Medium priority.Oct 14 2016, 7:14 PM

Sophivorus moved this task from Backlog to Bug reports on the ProveIt-Gadget board.Oct 26 2016, 3:07 PM

Change 318126 had a related patch set uploaded (by Sophivorus):
Support for nested templates

https://gerrit.wikimedia.org/r/318126

gerritbot added a project: Patch-For-Review.Oct 26 2016, 4:44 PM

Sophivorus mentioned this in rWGPI27e9111c6903: Support for nested templates.Oct 26 2016, 4:46 PM

The patch set linked by the bot was not meant for this task!

Sophivorus removed a project: Patch-For-Review.Oct 26 2016, 4:52 PM

Change 318982 had a related patch set uploaded (by Sophivorus):
Match specific subtemplate before general templates

https://gerrit.wikimedia.org/r/318982

gerritbot added a project: Patch-For-Review.Oct 31 2016, 8:10 PM

Sophivorus mentioned this in rWGPI80cb19e63dea: Match specific subtemplate before general templates.Oct 31 2016, 8:12 PM

Sophivorus mentioned this in rWGPI33b9c8f7fd2c: Match more specific templates first.Oct 31 2016, 8:25 PM

Sophivorus mentioned this in rWGPI2b88b9a19d83: Match more specific templates first.

Change 318982 merged by Sophivorus:
Match more specific templates first

https://gerrit.wikimedia.org/r/318982

The last patch should have fixed this issue, but didn't. I'm not sure why, will keep on investigating.

Sophivorus removed a project: Patch-For-Review.Nov 16 2016, 8:17 PM

• Mattflaschen-WMF added a subscriber: Mattflaschen-Personal.Dec 3 2016, 1:59 AM

Mattflaschen-Personal updated the task description. (Show Details)Feb 5 2017, 9:37 PM

Mattflaschen-Personal removed subscribers: Mattflaschen-Personal, • Mattflaschen-WMF.

Fixed! See https://ru.wikipedia.org/w/index.php?title=Богомоловые&action=edit for proof and add other "strange" templates to https://ru.wikipedia.org/wiki/MediaWiki:Gadget-ProveIt.js to add support for them too.

Restricted Application added a subscriber: Liuxinyu970226. · View Herald TranscriptSep 27 2019, 5:11 PM