Page MenuHomePhabricator

Provide simultaneous access to diff preview and edit summary
Open, LowPublic8 Story Points

Description

When the user clicks on "review your changes" in the save dialog, the edit summary gets hidden, making it cumbersome to compose a summary of multiple independent changes. There is no good reason not to show it in the diff view as well.

(T52961 is a suggestion to put the summary field in the edit view, which would also solve the problem but would be more confusing IMO as that view has much more controls and content.)

Event Timeline

Tgr created this task.Oct 15 2016, 7:09 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 15 2016, 7:09 PM
Jdforrester-WMF triaged this task as Low priority.Nov 8 2016, 8:15 PM
Jdforrester-WMF moved this task from To Triage to TR1: Releases on the VisualEditor board.
Jdforrester-WMF set the point value for this task to 8.
Jdforrester-WMF added a subscriber: Jdforrester-WMF.

You mean, the editable box containing the edit summary? We already provide the rendered preview of the edit summary there.

Nnemo awarded a token.Nov 11 2016, 4:45 PM
Nnemo added a subscriber: Nnemo.
Nnemo added a comment.Nov 11 2016, 5:03 PM

You mean, the editable box containing the edit summary? We already provide the rendered preview of the edit summary there.

I don't see such preview. When I type "[[art]]", I see "[[art]]", I don't see a link.

You mean, the editable box containing the edit summary? We already provide the rendered preview of the edit summary there.

In the visual editor, when I want to save my changes, the visual editor asks me: Edit summary? In this dialog, I click the button Relire vos modifications (Reread your changes). I see my changes — sometimes, they are numerous. But I cannot describe them in the edit summary, in this screen. In this screen, being able to see and to write the edit summary is missing.

Tgr added a comment.Nov 11 2016, 6:35 PM

Yeah, I meant the ability to type in the edit summary while looking at the diff. When you are trying to summarize an edit containing a number of unrelated changes, it is annoying to have to jump back and forth between the summary textbox and the diff.

Ideally, the summary box would always be on-screen while looking at the diff.

So you want to be able to edit the edit summary, *not* preview it, when looking at the diff?

Tgr added a comment.Nov 11 2016, 7:02 PM

So you want to be able to edit the edit summary, *not* preview it, when looking at the diff?

Exactly.

Nnemo added a comment.EditedNov 12 2016, 5:28 AM

@Jdforrester-WMF @Tgr

Ideally, the summary box would always be on-screen while looking at the diff.

Yes. Ideally, the box "Edit summary" would remain visible even when the contributor scrolls in the changes.