Page MenuHomePhabricator
Create Task
Maniphest T148366

Update pdf print stylesheet
Closed, ResolvedPublic
Actions

Assigned To
• Jhernandez
Authored By
• Jhernandez
Oct 17 2016, 8:00 AM
Tags
Referenced Files
F4681095: commons_103116.pdf
Oct 31 2016, 5:38 PM
F4663462: commons.pdf
Oct 26 2016, 4:30 PM
F4625355: render-1476872919904.pdf
Oct 19 2016, 10:35 AM
F4611243: Wikilater-print.css
Oct 17 2016, 8:00 AM
Subscribers
Aklapper
• aripstra
• atgo
• Jhernandez
• Nirzar
ovasileva
RHo

Description

Version sent by @RHo:

Wikilater-print.css7 KBDownload

Apply print styles to wikilater

Related Objects
Search...

Event Timeline

• Jhernandez created this task.Oct 17 2016, 8:00 AM

@RHo Do you want to provide mocks or do you want to signoff live when those current styles are applied (or both)?

• atgo moved this task from Backlog to Doing on the New-Readers board.Oct 17 2016, 9:13 AM
RHo reassigned this task from RHo to • Nirzar.Oct 17 2016, 1:23 PM

hey @Jhernandez – handing over to @Nirzar who will likely have some tweaks to the css first.

• atgo triaged this task as Medium priority.Oct 17 2016, 3:18 PM
• atgo moved this task from Doing to Epics in progress on the New-Readers board.
• Jhernandez moved this task from Incoming to Design on the Web-Team-Backlog board.Oct 17 2016, 3:20 PM
• Jhernandez edited projects, added Web-Team-Backlog (Design); removed Web-Team-Backlog.
• Nirzar moved this task from Needs analysis to Next up on the Web-Team-Backlog (Design) board.Oct 17 2016, 4:15 PM
• Nirzar moved this task from Next up to Designing/discussing right now on the Web-Team-Backlog (Design) board.
• Jhernandez added a comment.Oct 19 2016, 10:35 AM

@Nirzar I've uploaded the mentioned styles here: https://github.com/joakin/protowiki/blob/master/src/styles/print.css

You can see the results on the deployed https://wikilater-1.surge.sh/wiki/Cat if you print in chrome.

And you this is the service rendered pdf

render-1476872919904.pdf1 MBDownload
from the render service

• Jhernandez added a project: Reading-Web-Sprint-83-Y?.Oct 19 2016, 10:37 AM
• Jhernandez moved this task from Needs Analysis to Doing on the Reading-Web-Sprint-83-Y? board.
• Jhernandez added a project: Unplanned-Sprint-Work.
• Nirzar added a comment.Oct 20 2016, 11:41 PM

@Jhernandez https://github.com/joakin/protowiki/pull/3 pull request for css

• Jhernandez added a comment.Oct 21 2016, 1:39 PM

@Nirzar it's merged and deployed, have a look. If it's good then let's resolve this!

• Jhernandez moved this task from Doing to Ready for Signoff on the Reading-Web-Sprint-83-Y? board.Oct 21 2016, 1:48 PM
• NHarateh_WMF added a project: Reading-Web-Sprint-84-Zero-minutes-left.Oct 24 2016, 4:23 PM
Jdlrobson moved this task from Needs Analysis to Ready for Signoff on the Reading-Web-Sprint-84-Zero-minutes-left board.Oct 24 2016, 4:35 PM
• NHarateh_WMF removed a project: Unplanned-Sprint-Work.Oct 24 2016, 5:05 PM
• atgo added a comment.Oct 26 2016, 4:30 PM

commons.pdf517 KBDownload

The styling on this has some issues... images are doing a lot of weird things. Anything we can do?

• Nirzar added a comment.Oct 26 2016, 8:54 PM

@atgo looks like .thumbinner issue. i will fix it..

• Nirzar moved this task from Epics in progress to Sign-off needed on the New-Readers board.Oct 27 2016, 12:33 AM
ovasileva added a comment.Oct 31 2016, 3:55 PM

to @atgo for signoff

• atgo added a comment.Oct 31 2016, 5:31 PM

@Nirzar taking this from the design column to match with Reading-Web-Sprint-84-Zero-minutes-left

• atgo moved this task from Sign-off needed to Done on the New-Readers board.Oct 31 2016, 5:31 PM
• atgo added a comment.Oct 31 2016, 5:38 PM

Still looks weird on pages 7, 8, 9, etc.. Fixable?

commons_103116.pdf517 KBDownload

• atgo moved this task from Done to Sign-off needed on the New-Readers board.Oct 31 2016, 5:39 PM
• Nirzar added a comment.Oct 31 2016, 5:39 PM

@atgo I haven't fixed it yet.

• atgo added a comment.Oct 31 2016, 5:41 PM

@Nirzar got it. Moved it back to your column in New-Readers. Do we need to do the same in the Web board(s)?

ovasileva moved this task from Ready for Signoff to Needs More Work on the Reading-Web-Sprint-84-Zero-minutes-left board.Nov 1 2016, 12:14 PM

@Nirzar, @atgo - moved to needs more work

ovasileva added a project: Reading-Web-Sprint-85-💩.Nov 7 2016, 5:09 PM
ovasileva moved this task from Needs Analysis to Doing on the Reading-Web-Sprint-85-💩 board.Nov 7 2016, 5:17 PM
ovasileva moved this task from Doing to Ready for Signoff on the Reading-Web-Sprint-85-💩 board.
ovasileva moved this task from Ready for Signoff to Doing on the Reading-Web-Sprint-85-💩 board.
• atgo added a comment.Nov 18 2016, 1:28 AM

@Nirzar is this one ready for dev?

ovasileva added a comment.Nov 21 2016, 3:26 PM

@Nirzar - should we move this to next sprint for dev?

ovasileva added a project: Reading-Web-Sprint-86-🔪🦃.Nov 21 2016, 5:15 PM
MBinder_WMF moved this task from Design to Upcoming on the Web-Team-Backlog board.Nov 21 2016, 5:16 PM
MBinder_WMF edited projects, added Web-Team-Backlog; removed Web-Team-Backlog (Design).
Jdlrobson moved this task from Needs Analysis to Doing on the Reading-Web-Sprint-86-🔪🦃 board.Nov 21 2016, 5:17 PM
ovasileva moved this task from Upcoming to 2016-17 Q2 on the Web-Team-Backlog board.Nov 21 2016, 7:46 PM
• Nirzar added a comment.Nov 23 2016, 11:44 PM

https://github.com/joakin/protowiki/pull/7
PR for new print css which works with

• Nirzar reassigned this task from • Nirzar to • Jhernandez.Nov 23 2016, 11:49 PM
• Nirzar moved this task from Sign-off needed to Blocked on the New-Readers board.
• Jhernandez closed this task as Resolved.Nov 24 2016, 12:08 PM

Mergerd and deployerd

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL