Page MenuHomePhabricator

Extension loader ignores 'merge_strategy' key
Closed, ResolvedPublic

Description

This code from SemanticForms is the only instance of the "manifest_version": 2 that I found that tries to use merge_strategy, and it clearly fails because of the wrong variable used in the code. Fix is coming in a sec, and it will let us properly fix ZeroBanner config loading.

"sfgDatePickerSettings": {
	"value": {
		"@note": "See SF_DefaultInputSettings.php for allowed values",
		"FirstDate": null,
		...
	},
	"merge_strategy": "array_plus"
}

Event Timeline

Yurik created this task.Oct 18 2016, 4:45 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 18 2016, 4:45 AM

Change 316519 had a related patch set uploaded (by Yurik):
Fix extension loader ignoring 'merge_strategy' key

https://gerrit.wikimedia.org/r/316519

Change 316519 merged by jenkins-bot:
registration: Fix ignoring 'merge_strategy' key in manifest_version 2

https://gerrit.wikimedia.org/r/316519

Florian closed this task as Resolved.Oct 18 2016, 7:09 AM

Change 316531 had a related patch set uploaded (by Paladox):
registration: Fix ignoring 'merge_strategy' key in manifest_version 2

https://gerrit.wikimedia.org/r/316531

Change 316531 abandoned by Paladox:
registration: Fix ignoring 'merge_strategy' key in manifest_version 2

https://gerrit.wikimedia.org/r/316531