Page MenuHomePhabricator

video.js mode scrub bar displays backwards in RTL languages
Closed, ResolvedPublic

Description

In video.js mode, the scrub bar on video/audio player displays backwards, counting playtime from the right instead of from the left.

(Media controls should look the same in RTL as they do in LTR, which is to say "forward" is to the right. See T44471 for past problems with MwEmbedPlayer.)

This is probably an upstream video.js issue. seems to be a CSSJanus issue; upstream CSS works in isolation.

Event Timeline

brion created this task.Oct 18 2016, 6:15 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 18 2016, 6:15 PM
brion added a comment.Oct 18 2016, 6:32 PM

Isolated test case looks ok... I think it's CSSJanus running over the video-js.css file. Is there a way we can force "@noflip" on an entire file?

brion updated the task description. (Show Details)

Change 316611 had a related patch set uploaded (by Brion VIBBER):
Add 'noflip' option on RL modules to disable CSSJanus

https://gerrit.wikimedia.org/r/316611

Change 316612 had a related patch set uploaded (by Brion VIBBER):
Fix videojs mode control bar in RTL

https://gerrit.wikimedia.org/r/316612

Change 316611 merged by jenkins-bot:
Add 'noflip' option on RL modules to disable CSSJanus

https://gerrit.wikimedia.org/r/316611

Change 316612 merged by jenkins-bot:
Fix videojs mode control bar in RTL

https://gerrit.wikimedia.org/r/316612

TheDJ closed this task as Resolved.Oct 31 2016, 8:18 PM
TheDJ assigned this task to brion.
TheDJ edited projects, added TimedMediaHandler; removed Patch-For-Review.
TheDJ moved this task from Backlog to Done on the TimedMediaHandler board.