Page MenuHomePhabricator
Create Task
Maniphest T148679

Uncaught Error: Inserted data is trying to close the root node (at index 0) appears when pressing returen after deselecting some nodes
Closed, ResolvedPublic8 Estimated Story Points
Actions

Description

Steps to reproduce:

1.Select any Table/References list/ Hieroglyph
2.Click at the right end of it to deselect it.
3.Press return

Observed Result:

  1. There is no cursor appears at the end of the node when you deselect it by clicking at the right end of it.
  2. After pressing return, there is no cursor in the next line. The styling menu is disabled in the toolbar.

Also shows error in the console "Uncaught Error: Inserted data is trying to close the root node (at index 0).

Screen Shot 2016-10-19 at 8.32.48 PM.png (611×1 px, 106 KB)

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Update VE core submodule to master (e8188bac8)mediawiki/extensions/VisualEditormaster+1 -1
ce.Surface: handle table-adjacent observed selection changes betterVisualEditor/VisualEditormaster+23 -9
Update VE core submodule to master (cb52d8b7a)mediawiki/extensions/VisualEditormaster+1 -1
ce.Surface: in observed selection changes, only make cursorable selectionsVisualEditor/VisualEditormaster+21 -1
LinearEnterKeyDownHandler: make sure the range is in a cursorable locationVisualEditor/VisualEditormaster+6 -0
Customize query in gerrit

Related Objects

Event Timeline

Ryasmeen created this task.Oct 19 2016, 7:42 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 19 2016, 7:42 PM
Jdforrester-WMF triaged this task as Medium priority.Nov 8 2016, 8:23 PM
Jdforrester-WMF set the point value for this task to 8.
Jdforrester-WMF added a project: VisualEditor-ContentEditable.
Jdforrester-WMF moved this task from To Triage to TR1: Releases on the VisualEditor board.
gerritbot subscribed.Sep 27 2017, 4:51 PM

Change 381033 had a related patch set uploaded (by DLynch; owner: DLynch):
[VisualEditor/VisualEditor@master] LinearEnterKeyDownHandler: make sure the range is in a cursorable location

https://gerrit.wikimedia.org/r/381033

gerritbot added a project: Patch-For-Review.Sep 27 2017, 4:51 PM
Esanders subscribed.Sep 28 2017, 8:37 AM

Related: T176936

gerritbot added a comment.Sep 28 2017, 3:56 PM

Change 381235 had a related patch set uploaded (by DLynch; owner: DLynch):
[VisualEditor/VisualEditor@master] ce.Surface: in observed selection changes, only make cursorable selections

https://gerrit.wikimedia.org/r/381235

gerritbot added a comment.Sep 28 2017, 3:58 PM

Change 381033 abandoned by DLynch:
LinearEnterKeyDownHandler: make sure the range is in a cursorable location

Reason:
That's fair. I've put up I03348d34b3a2ffb5049acd4f62b4c568692e1649 as a suggested fix, stopping the surface from placing an invalid selection in response to observed events.

https://gerrit.wikimedia.org/r/381033

gerritbot added a comment.Sep 29 2017, 9:48 PM

Change 381235 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] ce.Surface: in observed selection changes, only make cursorable selections

https://gerrit.wikimedia.org/r/381235

gerritbot added a comment.Oct 2 2017, 4:53 PM

Change 381805 had a related patch set uploaded (by DLynch; owner: DLynch):
[VisualEditor/VisualEditor@master] ce.Surface: handle table-adjacent observed selection changes better

https://gerrit.wikimedia.org/r/381805

gerritbot added a comment.Oct 2 2017, 5:56 PM

Change 381814 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (cb52d8b7a)

https://gerrit.wikimedia.org/r/381814

gerritbot added a comment.Oct 3 2017, 5:06 AM

Change 381814 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (cb52d8b7a)

https://gerrit.wikimedia.org/r/381814

gerritbot added a comment.Oct 11 2017, 12:34 PM

Change 381805 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] ce.Surface: handle table-adjacent observed selection changes better

https://gerrit.wikimedia.org/r/381805

gerritbot added a comment.Oct 11 2017, 4:55 PM

Change 383612 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (e8188bac8)

https://gerrit.wikimedia.org/r/383612

gerritbot added a comment.Oct 11 2017, 5:18 PM

Change 383612 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (e8188bac8)

https://gerrit.wikimedia.org/r/383612

Jdforrester-WMF closed this task as Resolved.Oct 11 2017, 7:30 PM
Jdforrester-WMF assigned this task to DLynch.
Jdforrester-WMF edited projects, added MW-1.31-release-notes (WMF-deploy-2017-10-17 (1.31.0-wmf.4)); removed Patch-For-Review.
Jdforrester-WMF subscribed.

Sorry, RTB got confused.

Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptOct 11 2017, 7:30 PM
Ryasmeen added a project: Verified.Oct 12 2017, 12:11 AM
Ryasmeen added a project: Verified-in-Phase0.Oct 18 2017, 8:44 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits