Page MenuHomePhabricator

Maplinks external groups are applied multiples times
Closed, ResolvedPublic

Description

Steps to reproduce:

  • Create a maplink such as:
<maplink text="Alaska" zoom=3 longitude=-152.58 latitude=64.01>
{
  "type": "ExternalData",
  "service": "geoshape",
  "ids": "Q797"
}
</maplink>
  • Click on the maplink, see polygon color
  • Close, click on maplink several times, see the polygon color getting darker

Github issue: https://github.com/juliengirault/wikimedia-mapdata/issues/2

Details

Related Gerrit Patches:
mediawiki/extensions/Kartographer : masterFixes maplink external groups being applied multiple times

Event Timeline

JGirault created this task.Oct 19 2016, 9:25 PM
Restricted Application added a project: Discovery. · View Herald TranscriptOct 19 2016, 9:25 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 316903 had a related patch set uploaded (by JGirault):
Fixes maplink external groups being applied multiple times

https://gerrit.wikimedia.org/r/316903

JGirault moved this task from In progress to Needs review on the Maps-Sprint board.

Change 316903 merged by jenkins-bot:
Fixes maplink external groups being applied multiple times

https://gerrit.wikimedia.org/r/316903

Yurik added a subscriber: Yurik.Oct 21 2016, 4:57 AM

Upon further testing, seems like the bug is still there. Leaving it open.

Yurik moved this task from Needs review to In progress on the Maps-Sprint board.Oct 21 2016, 4:57 AM
Yurik closed this task as Resolved.Oct 21 2016, 6:45 PM

My bad, I confused it with T147608