OAuth authorization fails if account does not exist on the central wiki
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Tgr
	Oct 19 2016, 10:51 PM

Description

Steps to reproduce:

create a new account, make sure it exists (and is logged in) centrally but does not exist locally on the central OAuth wiki. (On WMF wikis this is only possible when the account autocreation script errors out.)
try to authorize an OAuth consumer on some non-central wiki

You will get Unified login needed, E008.

See T94885 for reports of this bug.

	Subject	Repo	Branch	Lines +/-
	Relax requirement of the user having an account on the central wiki	mediawiki/extensions/OAuth	master	+7 -11

Mentioned In: T147787: Can not to add user in the course. Ed Dashboard
T94885: OAuth: authorization fails if the user never visited a foreign wiki (and account was created before centralauth autocreation was enabled)
Mentioned Here: T94885: OAuth: authorization fails if the user never visited a foreign wiki (and account was created before centralauth autocreation was enabled)

Change 316914 had a related patch set uploaded (by Gergő Tisza):
Relax requirement for the user having an account on the central wiki

Is this just stuck waiting for code review? Would love to get the E008 issues wrapped up!

@Tgr what's the status with this?

Still waiting for CR. @Anomie do you have time to look at it? It's a fairly simple change.

Per Anomie, someone from Security should take a look at the patch.

SamanthaNguyen triaged this task as Lowest priority.Jan 8 2017, 12:01 AM

Change 316914 merged by jenkins-bot:
Relax requirement of the user having an account on the central wiki

Anomie closed this task as Resolved.Jan 18 2017, 3:49 PM

Anomie assigned this task to Tgr.