Page MenuHomePhabricator

Say "today" instead of "0 days ago" on the "Because you read" card
Closed, ResolvedPublic

Description

The "Because you read" card says "0 days ago" when the date is today.

It would be much better to say "Today", probably in all languages.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 316913 had a related patch set uploaded (by Amire80):
Add a "zero" value for view_continue_reading_card_subtitle

https://gerrit.wikimedia.org/r/316913

Change 316913 merged by jenkins-bot:
Say "today" when the date on the card is today

https://gerrit.wikimedia.org/r/316913

Hi @Niedzielski – this looks good, except can we capitalize "Today" :)

Screenshot_1478108982.png (1×1 px, 306 KB)

Change 319390 had a related patch set uploaded (by Niedzielski):
Capitalize "today" in because you read card titles

https://gerrit.wikimedia.org/r/319390

Change 319390 merged by jenkins-bot:
Capitalize "today" in because you read card titles

https://gerrit.wikimedia.org/r/319390

@Niedzielski - can we also capitalize 'yesterday' and apply the same logic to the Continue reading card?

Screenshot_1478266102.png (1×1 px, 525 KB)

Change 319877 had a related patch set uploaded (by Niedzielski):
Capitalize "yesterday" in feed card titles

https://gerrit.wikimedia.org/r/319877

I should have thought to do that when I capitalized "today". The continue read cards will also see the change thanks to @Amire80's earlier patch.

Change 319877 merged by jenkins-bot:
Capitalize "yesterday" in feed card titles

https://gerrit.wikimedia.org/r/319877