Bounding box in documentation should be changed
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Kbohrnsen
	Oct 20 2016, 5:31 PM

Description

"Bounding box with topleft and bottomright latlong coordinates" should be changed to "Bounding box with bottomleft and topright latlong coordinates".

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Ensure orderby is allways an array	labs/tools/heritage	master	+6 -4

Mentioned In: T140795: Map sources using Wikidata to wd_item
T148773: Error calling search with bounding box
Mentioned Here: rTHERc943e89d5d94: Pass positional arguments to nosetests via tox
rTHERe3ba1484f3e6: Mount SQL files via a volume instead of copying in Docker setup
rTHER063f9e2af2ab: Ensure orderby is allways an array
rTHER1db9f42031ad: Harvest Wikidata item for es-ct (ca)
rTHERfe119e139e33: Harvest Wikidata item for es-vc (ca)
rTHERde2e59055d6e: Harvest Wikidata item for fr (ca)
rTHER82147b8dde15: Harvest Wikidata item for ad (ca)
rTHERf6ff35055240: Harvest Wikidata item for es (ca)
rTHER63a1819d3fdc: Harvest Wikidata item for de-he (de)
T140795: Map sources using Wikidata to wd_item
T148773: Error calling search with bounding box

Right. We actually specify left,bottom,right,top on the row above only to contradict ourselves in the following line.

As a reference what we actually do in the code is:

$bl_lon = floatval( $coords[0] );
$bl_lat = floatval( $coords[1] );
$tr_lon = floatval( $coords[2] );
$tr_lat = floatval( $coords[3] );

Change 317524 had a related patch set uploaded (by Lokal Profil):
Ensure orderby is allways an array

Change 317524 merged by jenkins-bot:
Ensure orderby is allways an array

This is now deployed