| • Niedzielski | |
| Oct 20 2016, 8:21 PM |
| F5228219: pasted_file | |
| Jan 4 2017, 1:58 PM |
| F5228391: pasted_file | |
| Jan 4 2017, 1:58 PM |
| F5224286: screenshot-2017-01-03-14-07-03-214108444.png | |
| Jan 3 2017, 9:39 PM |
| F5224287: screenshot-2017-01-03-14-07-09-594747035.png | |
| Jan 3 2017, 9:39 PM |
| F5224290: screenshot-2017-01-03-14-37-07-147796185.png | |
| Jan 3 2017, 9:39 PM |
From the docs[0]:
Represents a standard bottom navigation bar for application. It is an implementation of material design bottom navigation[1].
[0] https://developer.android.com/reference/android/support/design/widget/BottomNavigationView.html
[1] https://material.google.com/components/bottom-navigation.html
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Update NavTabLayout to use BottomNavigationView | apps/android/wikipedia | master | +27 -157 |
Change 329227 had a related patch set uploaded (by Mhutti1):
Update NavTabLayout to use BottomNavigationView
BottomNavigationView doesn't seem to be appropriate for ArticleTabLayout in its current form as the buttons are actions not navigations. With more than 3 tabs the view is animated and it makes no sense to have an action continuously selected (and so larger than the others).
@RHo, are you cool with this change? This will let us use the latest and greatest Google components. Sample APK and screenshots below
hi @Niedzielski – no issue with changing to use the standard bottom navigation component. However, current screenshots show a couple of minor visual discrepancies with respect to application of the guidelines [1] which should be addressed:
[1] https://material.io/guidelines/components/bottom-navigation.html#bottom-navigation-style
So I spent some time trying to find the issue here and I think its with the support library. The issue also occurs in this project https://medium.com/@hitherejoe/exploring-the-android-design-support-library-bottom-navigation-drawer-548de699e8e0#.6qjobx3m9 if you add a 4th item to the menu. They havn't implemented their own guidelines right.
https://code.google.com/p/android/issues/detail?id=230653 fixes one of them.
@RHo Is it ok if I submit an issue to Google with your screenshots to fix the other?
I can add it to https://code.google.com/p/android/issues/detail?id=229845&q=BottomNavigationView&colspec=ID%20Status%20Priority%20Owner%20Summary%20Stars%20Reporter%20Opened
hi @Mhutti1 – yes, please feel free to submit the issues with my screenshot. And thanks for looking into these issues :)