Page MenuHomePhabricator
Create Task
Maniphest T148941

RadioInputWidget is not perfectly round
Closed, ResolvedPublic
Actions

Description

Another incident of sub-pixel rounding error, RadioInputWidget is from case to case not perfectly round.
Especially irritating when encountered in RadioSelectWidgets (groups of radios).

T148941 RadioInputWidget sub-pixel rendering - OOjs UI Demos 2016-10-23.png (134×187 px, 10 KB)

Details

SubjectRepoBranchLines +/-
MediaWiki theme: Address sub-pixel rendering issues of RadioInputWidgetsoojs/uimaster+1 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

Volker_E created this task.Oct 24 2016, 1:31 AM
Volker_E updated the task description. (Show Details)Oct 24 2016, 1:34 AM
SamanthaNguyen subscribed.Oct 24 2016, 11:49 PM
Jdforrester-WMF closed this task as Resolved.Nov 29 2016, 11:18 PM
Jdforrester-WMF edited projects, added OOUI (OOjs-UI-0.18.0); removed OOUI.
Volker_E reopened this task as Open.Nov 30 2016, 11:20 AM
Volker_E added a comment.Nov 30 2016, 11:23 AM

Remains open, the merged patches on adressing sizing issues differently haven't affected RadioInputs so far…

gerritbot subscribed.Dec 2 2016, 1:21 AM

Change 324848 had a related patch set uploaded (by VolkerE):
MediaWiki theme: Address sub-pixel rendering issues of RadioInputWidgets

https://gerrit.wikimedia.org/r/324848

gerritbot added a project: Patch-For-Review.Dec 2 2016, 1:21 AM
Volker_E raised the priority of this task from High to Needs Triage.Dec 2 2016, 1:22 AM
Volker_E moved this task from Backlog to Review on the UI-Standardization-Kanban board.
Jdforrester-WMF edited projects, added OOUI (OOjs-UI-0.18.2); removed OOUI (OOjs-UI-0.18.0).Dec 5 2016, 10:05 PM
Jdforrester-WMF triaged this task as Medium priority.Dec 5 2016, 10:08 PM
gerritbot added a comment.Dec 5 2016, 10:23 PM

Change 324848 merged by jenkins-bot:
MediaWiki theme: Address sub-pixel rendering issues of RadioInputWidgets

https://gerrit.wikimedia.org/r/324848

Volker_E closed this task as Resolved.Dec 5 2016, 11:54 PM
Volker_E removed a project: Patch-For-Review.
Volker_E moved this task from Review to Done on the UI-Standardization-Kanban board.Dec 6 2016, 12:00 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL