Undefined property: DeletedContribsPager::$newOnly in ContributionsFormatter::format
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Spotted one occurrence in the Wikimedia production logs:

Undefined property: DeletedContribsPager::$newOnly
in /srv/mediawiki/php-1.28.0-wmf.22/extensions/Flow/includes/Formatter/ContributionsFormatter.php on line 33

ContributionsFormatter::format

public function format( FormatterRow $row, IContextSource $ctx ) {
    …
    if ( $ctx->newOnly && !$isNewPage ) {
        return false;
    }
    …
}

Details

	Subject	Repo	Branch	Lines +/-
	Filter newOnly contribution in query instead of in formatter	mediawiki/extensions/Flow	master	+5 -4

Customize query in gerrit

Event Timeline

Dereckson created this task.Oct 24 2016, 3:03 PM

Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptOct 24 2016, 3:03 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Dereckson renamed this task from Undefined property: DeletedContribsPager::$newOnly in ContributionsFormatter to Undefined property: DeletedContribsPager::$newOnly in ContributionsFormatter::format.Oct 24 2016, 3:05 PM

Dereckson updated the task description. (Show Details)

So the IContextSource interface doesn't specify any $newOnly property.

• jmatazzoni moved this task from Untriaged to Flow Holding Area on the Collaboration-Team-Triage board.Nov 3 2016, 1:17 AM

Still a lot this Sunday. After a HTTP 5xx reqs/min spike, logs reported 44 times the issue on 1.29.0-wmf.1.

Change 320201 had a related patch set uploaded (by Sbisson):
Filter newOnly contribution in query instead of in formatter

https://gerrit.wikimedia.org/r/320201

gerritbot added a project: Patch-For-Review.Nov 7 2016, 2:44 PM

SBisson claimed this task.Nov 7 2016, 3:02 PM

SBisson edited projects, added Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016); removed Collaboration-Team-Triage.

SBisson moved this task from Untriaged to Needs Review on the Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016) board.

Change 320201 merged by jenkins-bot:
Filter newOnly contribution in query instead of in formatter

https://gerrit.wikimedia.org/r/320201

ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2016-11-08_(1.29.0-wmf.2)).Nov 7 2016, 9:00 PM

SBisson moved this task from Needs Review to QA Review on the Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016) board.Nov 15 2016, 12:07 PM

Checked https://logstash.wikimedia.org/app/kibana#/dashboard/ - no errors; the overall functionality of Special:DeletedContributions page seem to be fine.

Etonkovidova moved this task from QA Review to Product Review on the Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016) board.Nov 24 2016, 1:17 AM

• jmatazzoni closed this task as Resolved.Dec 14 2016, 7:55 PM

• mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:11 PM

Undefined property: DeletedContribsPager::$newOnly in ContributionsFormatter::formatClosed, ResolvedPublicPRODUCTION ERRORActions

Description

Details

Event Timeline

Undefined property: DeletedContribsPager::$newOnly in ContributionsFormatter::format
Closed, ResolvedPublicPRODUCTION ERROR
Actions