Chinese articles should update based on the current character set preference
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	digdog
	Oct 24 2016, 9:34 PM

Description

STEPS

iPhone preferred languages: zh-hant, en-US, zh-TW, ja
Installed Wikiapp released version (v5.2.1) from AppStore
Wikiapp's my languages: Chinese, Japanese, English
Wikiapp "Show languages on search" is ON
In v5.2.1, search "東大寺" with language 中文 selected
Tap 东大寺 from search result list
Hit home button to leave Wikiapp
Upgrade Wikiapp using TestFlight to v5.3.0, and open it from TestFlight after upgraded
In v5.3.0, go through setup pages
In v5.3.0, search "東大寺" with language 中文 selected
Tap 东大寺 from search result list

ACTUAL
Page content is still shown in Simp. Chinese

EXPECTED
Page content should be in Trad. Chinese

NOTE
Maybe this is cache issue? Maybe wikiapp needs to clean up existing Chinese cache for T134967, otherwise upgraded user wont see T134967 taking effect on previously searched content.

Related Objects

Mentioned In: T162318: Allow users to switch between Simplified and Traditional Chinese on the iOS app
rAPIOSa369c0c145a1: Merge pull request #995 from wikimedia/feature/cache-chinese/T149034
rAPIOSc6f975b115f9: Merge branch 'feature/cache-chinese/T149034' into alpha
rAPIOS2fe388fb218b: Merge branch 'develop' into feature/cache-chinese/T149034
rAPIOS79eaab0c7aab: Merge branch 'feature/cache-chinese/T149034' of github.com:wikimedia/wikipedia…
Mentioned Here: T134967: Need variant options for Chinese in Language Settings

Event Timeline

digdog created this task.Oct 24 2016, 9:34 PM

Restricted Application added a project: Wikipedia-iOS-App-Backlog. · View Herald TranscriptOct 24 2016, 9:34 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

• JMinor moved this task from Needs Triage to Bug Backlog on the Wikipedia-iOS-App-Backlog board.Oct 24 2016, 10:10 PM

• JMinor moved this task from Tasks from Product Backlog to Needs Engineering Sync on the iOS-app-v5.3.0-Welsh-Dragon board.Oct 25 2016, 6:13 PM

• JMinor moved this task from Needs Engineering Sync to Blocked or Waiting on the iOS-app-v5.3.0-Welsh-Dragon board.Oct 25 2016, 6:33 PM

Hi @digdog

We chose not to auto-update articles that have already been cached. We are worried about re-retreiving all the users articles in the background as the network data and device resource usage could be significant. Especially if you switch back and forth, each switch could be very expensive.

If the user refreshes the article by pulling down, the transformed version should be retrieved.

Couple questions for you:

Do you think we should auto-update the local pages after the user switches language choice?
If we don't autoupdate, should we refresh and transform it when you view the article?

• JMinor triaged this task as Medium priority.Oct 25 2016, 10:31 PM

Do you think we should auto-update the local pages after the user switches language choice?

No.

If we don't autoupdate, should we refresh and transform it when you view the article?

I'm not suggesting autoupdate, I'd prefer lazy update.

The scenario would be like:

User updated to v5.3.0
User tries to read the Chinese article that was cached on device
And T134967 result shows it should transfrom the cached article
Transform the cached article and show it to user

So for cached articles, it will be user initiated, lazy loading, only affecting particular cached Chinese article user selected, and user doesn't need to manually refresh the article.

See the steps described in the comment above for new expected behavior.

• Fjalapeno claimed this task.Oct 27 2016, 7:16 PM

• Fjalapeno moved this task from Ready for Development to Doing on the iOS-app-v5.3.0-Welsh-Dragon board.

• Fjalapeno moved this task from Doing to Needs Code Review on the iOS-app-v5.3.0-Welsh-Dragon board.Oct 27 2016, 7:45 PM

JoeWalsh mentioned this in rAPIOS79eaab0c7aab: Merge branch 'feature/cache-chinese/T149034' of github.com:wikimedia/wikipedia….Oct 28 2016, 12:15 PM

JoeWalsh mentioned this in rAPIOS2fe388fb218b: Merge branch 'develop' into feature/cache-chinese/T149034.

JoeWalsh mentioned this in rAPIOSc6f975b115f9: Merge branch 'feature/cache-chinese/T149034' into alpha.Oct 28 2016, 12:53 PM

• Fjalapeno mentioned this in rAPIOSa369c0c145a1: Merge pull request #995 from wikimedia/feature/cache-chinese/T149034.Oct 28 2016, 4:59 PM

• Fjalapeno moved this task from Needs Code Review to Needs Testing Criteria on the iOS-app-v5.3.0-Welsh-Dragon board.Oct 28 2016, 11:49 PM

To test:

Install app store version
Set device language to Chinese simplified
Save 3 articles (verify they are in traditional Chinese)
Install beta
Open the app
Go to save pages
Open the saved articles and verify they are reloaded as simplified chinese

• Fjalapeno moved this task from Needs Testing Criteria to Needs QA on the iOS-app-v5.3.0-Welsh-Dragon board.Oct 28 2016, 11:55 PM

Tested on iPhone 6S (iOS 10.0.1), and updated from the app store version to TestFlight's 5.3.0 (966) during testing. Two of the attached screencaps below, that were taken two minutes apart during testing, have some character differences that indicates that the article changed from traditional to simplified Chinese.