Page MenuHomePhabricator

Chinese articles should update based on the current character set preference
Closed, ResolvedPublic

Description

STEPS

  1. iPhone preferred languages: zh-hant, en-US, zh-TW, ja
  2. Installed Wikiapp released version (v5.2.1) from AppStore
  3. Wikiapp's my languages: Chinese, Japanese, English
  4. Wikiapp "Show languages on search" is ON
  5. In v5.2.1, search "東大寺" with language 中文 selected
  6. Tap 东大寺 from search result list
  7. Hit home button to leave Wikiapp
  8. Upgrade Wikiapp using TestFlight to v5.3.0, and open it from TestFlight after upgraded
  9. In v5.3.0, go through setup pages
  10. In v5.3.0, search "東大寺" with language 中文 selected
  11. Tap 东大寺 from search result list

ACTUAL
Page content is still shown in Simp. Chinese

EXPECTED
Page content should be in Trad. Chinese

NOTE
Maybe this is cache issue? Maybe wikiapp needs to clean up existing Chinese cache for T134967, otherwise upgraded user wont see T134967 taking effect on previously searched content.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Hi @digdog

We chose not to auto-update articles that have already been cached. We are worried about re-retreiving all the users articles in the background as the network data and device resource usage could be significant. Especially if you switch back and forth, each switch could be very expensive.

If the user refreshes the article by pulling down, the transformed version should be retrieved.

Couple questions for you:

  • Do you think we should auto-update the local pages after the user switches language choice?
  • If we don't autoupdate, should we refresh and transform it when you view the article?
JMinor triaged this task as Medium priority.Oct 25 2016, 10:31 PM
  • Do you think we should auto-update the local pages after the user switches language choice?

No.

  • If we don't autoupdate, should we refresh and transform it when you view the article?

I'm not suggesting autoupdate, I'd prefer lazy update.

The scenario would be like:

  1. User updated to v5.3.0
  2. User tries to read the Chinese article that was cached on device
  3. And T134967 result shows it should transfrom the cached article
  4. Transform the cached article and show it to user

So for cached articles, it will be user initiated, lazy loading, only affecting particular cached Chinese article user selected, and user doesn't need to manually refresh the article.

JMinor renamed this task from Fix for T134967 seems not working when upgraded from released version to v5.3.0 to Chinese articles should update based on the current character set preference.Oct 27 2016, 5:51 PM

See the steps described in the comment above for new expected behavior.

To test:

  1. Install app store version
  2. Set device language to Chinese simplified
  3. Save 3 articles (verify they are in traditional Chinese)
  4. Install beta
  5. Open the app
  6. Go to save pages
  7. Open the saved articles and verify they are reloaded as simplified chinese

Tested on iPhone 6S (iOS 10.0.1), and updated from the app store version to TestFlight's 5.3.0 (966) during testing. Two of the attached screencaps below, that were taken two minutes apart during testing, have some character differences that indicates that the article changed from traditional to simplified Chinese.

T149034 (Traditional).PNG (1×750 px, 826 KB)

T149034 (Simplified).PNG (1×750 px, 816 KB)

@digdog this fix should be included in next public beta, to be released on TestFlight in the next couple days.

I can verify this is fixed in 5.3.0 (667), thanks!

Great. Thanks for your help fixing this.