[Regression wmf.23] MW's title suggestion widget displays a suggestion for "foo" and "Foo" for non-existing pages on input of "foo" (OK), and for "Foo" and "Foo" on input of "Foo" (not OK)
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To

Authored By

	Etonkovidova
	Oct 25 2016, 9:46 PM

Description

The issue is present on beta too.

On testwiki with wmf.23, on a page in VE mode, click on 'Link'
In the Link inspector text box start typing non-existing page title.
The list of suggested articles will display two identical suggestions with 'page does not exist yet'

Screen Shot 2016-10-25 at 2.28.55 PM.png (287×560 px, 36 KB)

Screen Shot 2016-10-25 at 2.28.15 PM.png (394×644 px, 37 KB)

In wmf.22 only one suggestion will be displayed:

Screen Shot 2016-10-25 at 2.31.34 PM.png (326×713 px, 41 KB)

Details

Subject	Repo	Branch	Lines +/-
Follow-up Id0021594: Remove extra code for redlink suggestions	mediawiki/core	REL1_28	+7 -15
Follow-up Id0021594: Remove extra code for redlink suggestions	mediawiki/core	master	+7 -15
Follow-up Id0021594: Remove extra code for redlink suggestions	mediawiki/core	wmf/1.29.0-wmf.1	+7 -15

Customize query in gerrit

Related Objects

Duplicates Merged Here: T149818: Search results in link tool lists red-links twice

Event Timeline

Etonkovidova created this task.Oct 25 2016, 9:46 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 25 2016, 9:46 PM

Etonkovidova renamed this task from [regression pre-wmf.23] VE links suggestion list displays double for non-existing pages to [regression pre-wmf.23] VE link inspector displays double suggestions for non-existing pages.Oct 25 2016, 9:47 PM

Paladox added a project: VisualEditor.Oct 26 2016, 1:23 AM

Paladox added a project: Regression.

Jdforrester-WMF renamed this task from [regression pre-wmf.23] VE link inspector displays double suggestions for non-existing pages to [Regression wmf.23] MW's title suggestion widget displays a suggestion for "foo" and "Foo" for non-existing pages on input of "foo" (OK), and for "Foo" and "Foo" on input of "Foo" (not OK).Oct 26 2016, 10:14 PM

Jdforrester-WMF triaged this task as Medium priority.

Jdforrester-WMF added a project: MediaWiki-General.

Jdforrester-WMF set the point value for this task to 1.

Jdforrester-WMF added a subscriber: Esanders.

Change 318475 had a related patch set uploaded (by Alex Monk):
Follow-up Id0021594: Remove extra code for redlink suggestions

https://gerrit.wikimedia.org/r/318475

gerritbot added a project: Patch-For-Review.Oct 28 2016, 12:32 AM

• AlexMonk-WMF claimed this task.Oct 28 2016, 12:33 AM

Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.Oct 31 2016, 5:45 PM

Esanders merged a task: T149818: Search results in link tool lists red-links twice.Nov 2 2016, 8:03 PM

Esanders added a subscriber: • Whatamidoing-WMF.

Change 318475 merged by jenkins-bot:
Follow-up Id0021594: Remove extra code for redlink suggestions

https://gerrit.wikimedia.org/r/318475

ReleaseTaggerBot added projects: MW-1.29-release (WMF-deploy-2016-11-08_(1.29.0-wmf.2)), MW-1.29-release-notes.Nov 2 2016, 10:00 PM

Change 319481 had a related patch set uploaded (by Jforrester):
Follow-up Id0021594: Remove extra code for redlink suggestions

https://gerrit.wikimedia.org/r/319481

Change 319482 had a related patch set uploaded (by Jforrester):
Follow-up Id0021594: Remove extra code for redlink suggestions

https://gerrit.wikimedia.org/r/319482

It's now merged in master (what will become MW 1.29.0-wmf.2), and I'll backport it to wmf.1 for production fix tomorrow. However, we probably want to get it into 1.28.0, so tagging as such.

Jdforrester-WMF added a project: MW-1.28-release.Nov 2 2016, 10:51 PM

Change 319482 merged by jenkins-bot:
Follow-up Id0021594: Remove extra code for redlink suggestions

https://gerrit.wikimedia.org/r/319482

Jdforrester-WMF edited projects, added MW-1.28-release-notes; removed MW-1.29-release-notes, Patch-For-Review.Nov 2 2016, 11:52 PM

Change 319481 merged by jenkins-bot:
Follow-up Id0021594: Remove extra code for redlink suggestions

https://gerrit.wikimedia.org/r/319481

OK, now deployed to 1.29.0-wmf.1. Not worth pushing to 1.28.0-wmf.23 for just a few hours.

Mentioned in SAL (#wikimedia-operations) [2016-11-03T00:28:48Z] <dereckson@tin> Synchronized php-1.29.0-wmf.1/resources/src/mediawiki.widgets/mw.widgets.TitleWidget.js: Follow-up Id0021594: Remove extra code for redlink suggestions (T149130) (duration: 00m 46s)

ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2016-11-01_(1.29.0-wmf.1)).Nov 3 2016, 1:00 AM

	F4660617: Screen Shot 2016-10-25 at 2.31.34 PM.png
	Oct 25 2016, 9:46 PM

	F4660610: Screen Shot 2016-10-25 at 2.28.55 PM.png
	Oct 25 2016, 9:46 PM

	F4660612: Screen Shot 2016-10-25 at 2.28.15 PM.png
	Oct 25 2016, 9:46 PM

[Regression wmf.23] MW's title suggestion widget displays a suggestion for "foo" and "Foo" for non-existing pages on input of "foo" (OK), and for "Foo" and "Foo" on input of "Foo" (not OK)Closed, ResolvedPublic1 Estimated Story PointsActions

Description

Details

Related Objects

Event Timeline

[Regression wmf.23] MW's title suggestion widget displays a suggestion for "foo" and "Foo" for non-existing pages on input of "foo" (OK), and for "Foo" and "Foo" on input of "Foo" (not OK)
Closed, ResolvedPublic1 Estimated Story Points
Actions