Page MenuHomePhabricator
Create Task
Maniphest T149137

Show contribution tracking ID in Ingenico error messages as full 'External Reference #'
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

This is so great it deserves its own task - spinning off from T147679: Show contribution tracking ID in error messages as 'Reference #':

For Ingenico, what shows in the error message is the first part of the External Reference number, for example: 38905280. We're unable to search by these partial numbers. Would it be possible to update this, so that the full External Reference number (including the '.' and the number to the right of it) appears in the error message? For this example the full # is 38905280.37037. The Order ID for this one is 4279351834. This would be hugely helpful in finding elusive transactions, and give a real boost to our donor response times especially during Big English.

This is so useful that the more PSPs we can deploy it for, the better

Details

SubjectRepoBranchLines +/-
Update inline error reference to use order_idmediawiki/extensions/DonationInterfacemaster+6 -1
Use order id as error reference when possiblemediawiki/extensions/DonationInterfacemaster+4 -1
Customize query in gerrit

Related Objects

Event Timeline

MBeat33 created this task.Oct 25 2016, 9:56 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 25 2016, 9:56 PM
MBeat33 added subscribers: • Ppena, • DStrine.Oct 25 2016, 9:57 PM
• DStrine set the point value for this task to 1.Oct 26 2016, 10:43 PM
• DStrine moved this task from Triage to Sprint +1 on the Fundraising-Backlog board.
• DStrine moved this task from Sprint +1 to Completed in Q2 1617 on the Fundraising-Backlog board.Oct 26 2016, 10:45 PM
• DStrine added a project: Fundraising Sprint Unbreaking Now.Oct 26 2016, 10:49 PM
Ejegg claimed this task.Oct 27 2016, 10:10 PM
Ejegg moved this task from Backlog to Doing on the Fundraising Sprint Unbreaking Now board.
gerritbot subscribed.Oct 31 2016, 10:45 PM

Change 319002 had a related patch set uploaded (by Ejegg):
Use order id as error reference when possible

https://gerrit.wikimedia.org/r/319002

gerritbot added a project: Patch-For-Review.Oct 31 2016, 10:45 PM
Ejegg moved this task from Doing to Review on the Fundraising Sprint Unbreaking Now board.Oct 31 2016, 11:51 PM
Ejegg moved this task from Review to Pending Deployment on the Fundraising Sprint Unbreaking Now board.Nov 1 2016, 10:44 PM
gerritbot added a comment.Nov 1 2016, 10:49 PM

Change 319002 merged by jenkins-bot:
Use order id as error reference when possible

https://gerrit.wikimedia.org/r/319002

ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2016-11-08_(1.29.0-wmf.2)).Nov 2 2016, 7:01 PM
Ejegg moved this task from Pending Deployment to Done on the Fundraising Sprint Unbreaking Now board.Nov 2 2016, 7:59 PM
Ejegg added a comment.Nov 2 2016, 9:23 PM

This is deployed - the error should now show the order id when that's set (in Ingenico's case, this is the longer number, not the decimal), and fall back to ct_id when that's missing.

Ejegg closed this task as Resolved.Nov 2 2016, 9:23 PM
• DStrine added a project: FR-Ingenico.Nov 16 2016, 6:10 PM
gerritbot added a comment.Nov 21 2016, 8:48 PM

Change 322734 had a related patch set uploaded (by Ejegg):
Update inline error reference to use order_id

https://gerrit.wikimedia.org/r/322734

gerritbot added a comment.Nov 21 2016, 9:38 PM

Change 322734 merged by jenkins-bot:
Update inline error reference to use order_id

https://gerrit.wikimedia.org/r/322734

MBeat33 added a comment.EditedNov 22 2016, 2:54 PM

@Ejegg, this looks great (and thanks to whoever put the x to dismiss the email autosuggest!). One question, the error reference in this example 1738580923 does not appear as an Order ID (or any other searchable parameter) at the console. Is this a ct_id number, and if so, is there any way we can use that kind of number to determine why a given donor's attempt failed?

I've seen a few of these already today, where the error reference # that the donor sends does not appear at the portal (8066250153 is another), and want to know what the best messaging for these cases would be.

1738580923.jpg (1×902 px, 91 KB)

Ejegg added a comment.Nov 22 2016, 4:28 PM

These two were ones where the Insert_OrderWithPayment call failed. Somehow we sent a country code=XX - I'll look into that.

• DStrine reopened this task as Open.Nov 22 2016, 6:59 PM
• DStrine moved this task from Completed in Q2 1617 to Triage on the Fundraising-Backlog board.
• ggellerman closed this task as Resolved.Nov 22 2016, 10:11 PM
Ejegg mentioned this in T151411: Investigate country code = XX making it to Ingenico.Nov 22 2016, 10:13 PM
ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2016-11-29_(1.29.0-wmf.4)).Nov 27 2016, 11:01 PM
• DStrine moved this task from Triage to Closed Early/Declined/Invalid Tasks on the Fundraising-Backlog board.Jul 6 2017, 4:48 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL