Remove static background from mapframes after going dynamic
Closed, ResolvedPublic
Actions

Description

Create a static mapframe, click on it to activate, drag the map around. While new tiles are getting loaded, the static map can be seen under them, adding confusion. Probably, worth replacing it with gray background after initial tiles are loaded?

Details

	Subject	Repo	Branch	Lines +/-
	Remove static background image once the map is interactive	mediawiki/extensions/Kartographer	wmf/1.29.0-wmf.1	+3 -0
	Remove static background image once the map is interactive	mediawiki/extensions/Kartographer	master	+3 -0

Customize query in gerrit

Related Objects

Duplicates Merged Here: T149231: Mapframe is displaying odd map

Event Timeline

MaxSem created this task.Oct 26 2016, 1:16 AM

Restricted Application added a project: Discovery-ARCHIVED. · View Herald TranscriptOct 26 2016, 1:16 AM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

@MaxSem, please recheck if this bug is still valid. Cannot repo.

This seems like a valid bug to me. I was previously clearing the inline background-image property once interactive, but during a code cleanup this line went away.

• JGirault claimed this task.Oct 26 2016, 4:02 PM

• JGirault moved this task from Backlog to In progress on the Maps-Sprint board.

Change 318115 had a related patch set uploaded (by JGirault):
Remove static background image once the map is interactive

https://gerrit.wikimedia.org/r/318115

gerritbot added a project: Patch-For-Review.Oct 26 2016, 4:07 PM

• JGirault moved this task from In progress to Needs review on the Maps-Sprint board.Oct 26 2016, 4:07 PM

MaxSem merged a task: T149231: Mapframe is displaying odd map.Oct 26 2016, 7:31 PM

MaxSem added a subscriber: debt.

Change 318115 merged by jenkins-bot:
Remove static background image once the map is interactive

https://gerrit.wikimedia.org/r/318115

ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2016-11-01_(1.29.0-wmf.1)).Oct 26 2016, 9:00 PM

MaxSem moved this task from Needs triage to Maps on the Discovery-ARCHIVED board.Oct 26 2016, 9:20 PM

MaxSem closed this task as Resolved.Oct 26 2016, 9:51 PM

K4-713 subscribed.Oct 28 2016, 5:42 PM

ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2016-11-08_(1.29.0-wmf.2)).Nov 2 2016, 4:01 PM

Change 319354 had a related patch set uploaded (by Yurik):
Remove static background image once the map is interactive

https://gerrit.wikimedia.org/r/319354

Change 319354 abandoned by Yurik:
Remove static background image once the map is interactive

Reason:
wow. Weird - dup code passed all the tests/merges by git somehow. Abandoning.