Maniphest T149201

Remove jshint and jscs in favor of eslint (linting and code style) in Reading Web code
Closed, ResolvedPublic3 Estimated Story Points
Actions

Description

See parent task T118941: Switch to eslint for our linting and our code styling in all Wikimedia JavaScript code

In April 2016, JSCS maintainers joined the ESLint team.

JSCS, the code style linting tool we use in our extensions is end of life and unmaintained going forward.

We need to migrate our extensions to use eslint using the eslint-config-wikimedia preset and remove usage of jscs.

Also, since eslint can perform also the same checks as jshint, we can get rid of it in the process.

Plan

Migrate QuickSurveys to eslint
- https://gerrit.wikimedia.org/r/355410
Migrate Cards to eslint
- https://gerrit.wikimedia.org/r/355419
Migrate Wikidata-Page-Banner to eslint
- https://gerrit.wikimedia.org/r/355420

Details

Project	Branch	Lines +/-	Subject
mediawiki/extensions/Cards	master	+0 -2	Hygiene: Remove unused dependencies
mediawiki/extensions/QuickSurveys	master	+149 -157	Tools: Use eslint instead of jshint & jscs
mediawiki/extensions/Cards	master	+52 -65	Tools: Use eslint instead of jshint & jscs
mediawiki/extensions/WikidataPageBanner	master	+26 -50	Tools: Use eslint instead of jshint and jscs

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	None	T118941 Switch to eslint for our linting and our code styling in all Wikimedia JavaScript code
Resolved	Jdlrobson	T162936 Improve developer happiness in reading web maintained extensions
Resolved	• Jhernandez	T149201 Remove jshint and jscs in favor of eslint (linting and code style) in Reading Web code
Resolved	• bmansurov	T149202 Migrate RelatedArticles to eslint

Event Timeline

• Jhernandez created this task.Oct 26 2016, 3:24 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 26 2016, 3:24 PM

@ovasileva @bmansurov The parent task has been discussed and unstalled since for example VE already uses eslint instead of jscs.

I've created T149202: Migrate RelatedArticles to eslint as a first step to figure out any problems in a small extension before we make the changes to bigger codebases.

Paladox added a subscriber: Paladox.Oct 26 2016, 4:06 PM

• bmansurov triaged this task as Medium priority.Oct 26 2016, 8:14 PM

• bmansurov moved this task from Incoming to Triaged but Future on the Web-Team-Backlog board.

• bmansurov moved this task from Uncategorized to Team Workflows/Internal on the Technical-Debt (RW-Tech-Debt) board.Nov 2 2016, 7:36 PM

hashar merged a task: T154924: Remove jshint from V+1 as well as V+2 pipes for repos that use eslint now.Jan 20 2017, 11:49 AM

hashar added subscribers: Jdforrester-WMF, DatGuy.

@hashar: If you're going to merge T154924 in as a duplicate, could you do the work? That is not for future change-over (repos not yet converted), it's for repos already converted but no-one cleaned up the CI config, like WikiEditor and others.

Jdlrobson renamed this task from Remove jshint and jscs in favor eslint (linting and code style) to [EPIC] Remove jshint and jscs in favor eslint (linting and code style).Feb 10 2017, 7:36 PM

Jdlrobson moved this task from Triaged but Future to Epics/Goals on the Web-Team-Backlog board.

Related pages was pretty straightforward... but related pages is a small amount of code.
QuickSurveys, Cards or Wikidata-Page-Banner are probably worthy next targets.

• bmansurov closed subtask T149202: Migrate RelatedArticles to eslint as Resolved.Apr 10 2017, 7:29 PM

Jdlrobson added a parent task: T162936: Improve developer happiness in reading web maintained extensions.Apr 13 2017, 11:15 PM

^ I think that covers all the extensions we need to migrate?

Jdlrobson raised the priority of this task from Medium to High.Apr 20 2017, 11:15 PM

Jdforrester-WMF renamed this task from [EPIC] Remove jshint and jscs in favor eslint (linting and code style) to [EPIC] Remove jshint and jscs in favor of eslint (linting and code style) in Reading Web code.Apr 20 2017, 11:28 PM

Seems about right

Wondering if this is an epic or an 8 pointer. I feel like it would be good to do all these at the same time.

Jdlrobson renamed this task from [EPIC] Remove jshint and jscs in favor of eslint (linting and code style) in Reading Web code to Remove jshint and jscs in favor of eslint (linting and code style) in Reading Web code.May 10 2017, 12:24 PM

Jdlrobson removed a project: Epic.

I've done a quick run in Quicksurveys and cards and there are between 30 and 60 warnings there, of which 90% are because those projects use mw directly.

This should be a 5 pointer tops. Or a few tasks of 1 or 2 points if wanted.

We chatted about this. Most of the warnings are around mw not being defined. Should be straightforward to fix.

ovasileva added a project: Readers-Web-Kanbanana-Board-Old.May 17 2017, 11:05 AM

• NHarateh_WMF moved this task from To Do to Needs Design Review on the Readers-Web-Kanbanana-Board-Old board.May 17 2017, 5:37 PM

Jdlrobson moved this task from Upcoming to 2016-17 Q4 on the Web-Team-Backlog board.May 17 2017, 5:54 PM

• Jhernandez claimed this task.May 23 2017, 12:01 PM

• Jhernandez moved this task from Needs Design Review to Doing on the Readers-Web-Kanbanana-Board-Old board.

Change 355410 had a related patch set uploaded (by Jhernandez; owner: Jhernandez):
[mediawiki/extensions/QuickSurveys@master] Tools: Use eslint instead of jshint & jscs

https://gerrit.wikimedia.org/r/355410

gerritbot added a project: Patch-For-Review.May 24 2017, 10:35 AM

Diffusion mentioned this in rEQS7833634aa69a: Tools: Use eslint instead of jshint & jscs.May 24 2017, 10:41 AM

Diffusion mentioned this in rEQSa359dde4db3f: Tools: Use eslint instead of jshint & jscs.

Change 355419 had a related patch set uploaded (by Jhernandez; owner: Jhernandez):
[mediawiki/extensions/Cards@master] Tools: Use eslint instead of jshint & jscs

https://gerrit.wikimedia.org/r/355419

Change 355420 had a related patch set uploaded (by Jhernandez; owner: Jhernandez):
[mediawiki/extensions/WikidataPageBanner@master] Tools: Use eslint instead of jshint and jscs

https://gerrit.wikimedia.org/r/355420

• Jhernandez updated the task description. (Show Details)May 24 2017, 11:19 AM

• Jhernandez moved this task from Doing to Needs Code Review on the Readers-Web-Kanbanana-Board-Old board.May 24 2017, 11:23 AM

Jdlrobson moved this task from Needs Code Review to Ready for Signoff on the Readers-Web-Kanbanana-Board-Old board.May 24 2017, 9:06 PM

Change 355420 merged by jenkins-bot:
[mediawiki/extensions/WikidataPageBanner@master] Tools: Use eslint instead of jshint and jscs

https://gerrit.wikimedia.org/r/355420

Change 355419 merged by jenkins-bot:
[mediawiki/extensions/Cards@master] Tools: Use eslint instead of jshint & jscs

https://gerrit.wikimedia.org/r/355419

Change 355410 merged by jenkins-bot:
[mediawiki/extensions/QuickSurveys@master] Tools: Use eslint instead of jshint & jscs

https://gerrit.wikimedia.org/r/355410

Baha, would you mind signing this off?

OK, I'll do so.

ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-05-30_(1.30.0-wmf.3)).May 24 2017, 10:01 PM

The Cards extension still depends on grunt-contrib-jshint and grunt-jscs.

• bmansurov reassigned this task from • bmansurov to • Jhernandez.May 24 2017, 10:22 PM

Change 355621 had a related patch set uploaded (by Jhernandez; owner: Jhernandez):
[mediawiki/extensions/Cards@master] Hygiene: Remove unused dependencies

https://gerrit.wikimedia.org/r/355621

Good catch @bmansurov. I missed that one.

• bmansurov moved this task from Needs Code Review to Ready for Signoff on the Readers-Web-Kanbanana-Board-Old board.May 25 2017, 4:18 PM

Change 355621 merged by jenkins-bot:
[mediawiki/extensions/Cards@master] Hygiene: Remove unused dependencies

https://gerrit.wikimedia.org/r/355621

• bmansurov closed this task as Resolved.May 25 2017, 4:32 PM

Mass-moving all items tagged for MediaWiki 1.30.0-wmf.3, as that was never released; instead, we're using -wmf.4.

Remove jshint and jscs in favor of eslint (linting and code style) in Reading Web codeClosed, ResolvedPublic3 Estimated Story PointsActions