When wmf-auto-reimage's -c flag is used to depool in conftool, it seems to assume only one service will be returned for the host (which is true on e.g. appservers). Some hosts have multiple services, and the conftool output in this case is one complete JSON "document" per service on separate lines. It parses the whole of the conftool output as a single JSON document, which then fails JSON parsing...
Description
Description
Details
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| conftool: add --host option | operations/software/conftool | 0.3.x | +50 -0 | |
| conftool: add --host option | operations/software/conftool | master | +50 -0 |
Related Objects
Related Objects
- Mentioned Here
- T166300: Remove Salt from wmf-auto-reimage / wmf-reimage
Event Timeline
Comment Actions
The fix was sent to the other task I've merged into this one: https://gerrit.wikimedia.org/r/#/c/318131/
Comment Actions
Change 318550 had a related patch set uploaded (by Volans):
conftool: add --host option
Comment Actions
Change 320367 had a related patch set uploaded (by Giuseppe Lavagetto):
conftool: add --host option
Comment Actions
With the refactoring for T166300 this problem will be naturally solved moving from a shellout to confctl to the use of the conftool library. Resolving.