Page MenuHomePhabricator
Create Task
Maniphest T149232

[bug] globalblocking fatal in 1.28.0-wmf.23 -
Closed, ResolvedPublic
Actions

Description

reproduce:

https://www.mediawiki.org/w/api.php?bgip=127.0.4.4&format=json&action=query&maxlag=5&bgprop=address&list=globalblocks&bglimit=1

seems related to: https://gerrit.wikimedia.org/r/#/c/316226/

log error:

{"id":"WBD7xApAIEAAADA-fP0AAAFQ","type":"BadMethodCallException","file":"/srv/mediawiki/php-1.28.0-wmf.23/extensions/GlobalBlocking/includes/api/ApiQueryGlobalBlocks.php","line":98,"message":"Call to a member function buildLike() on a non-object (null)","

Details

SubjectRepoBranchLines +/-
Invoke database connection in ApiQueryGlobalBlocks::executemediawiki/extensions/GlobalBlockingwmf/1.28.0-wmf.23+1 -0
Invoke database connection in ApiQueryGlobalBlocks::executemediawiki/extensions/GlobalBlockingmaster+1 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

Matanya created this task.Oct 26 2016, 6:55 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 26 2016, 6:55 PM
Matanya added a parent task: T147517: MW-1.28.0-wmf.23 deployment blockers.Oct 26 2016, 6:55 PM
Matanya updated the task description. (Show Details)Oct 26 2016, 6:59 PM
Matanya added a subscriber: Glaisher.
Dereckson subscribed.Oct 26 2016, 7:50 PM

Issue is ApiQueryGlobalBlocks::execute doesn't define $dbr.

Dereckson claimed this task.Oct 26 2016, 7:53 PM
gerritbot subscribed.Oct 26 2016, 8:00 PM

Change 318158 had a related patch set uploaded (by Dereckson):
Invoke database connection in ApiQueryGlobalBlocks::execute

https://gerrit.wikimedia.org/r/318158

gerritbot added a project: Patch-For-Review.Oct 26 2016, 8:00 PM
gerritbot added a comment.Oct 26 2016, 8:05 PM

Change 318160 had a related patch set uploaded (by 20after4):
Invoke database connection in ApiQueryGlobalBlocks::execute

https://gerrit.wikimedia.org/r/318160

gerritbot added a comment.Oct 26 2016, 8:12 PM

Change 318158 merged by jenkins-bot:
Invoke database connection in ApiQueryGlobalBlocks::execute

https://gerrit.wikimedia.org/r/318158

gerritbot added a comment.Oct 26 2016, 8:12 PM

Change 318160 merged by jenkins-bot:
Invoke database connection in ApiQueryGlobalBlocks::execute

https://gerrit.wikimedia.org/r/318160

Stashbot subscribed.Oct 26 2016, 8:28 PM

Mentioned in SAL (#wikimedia-operations) [2016-10-26T20:28:42Z] <twentyafterfour@tin> Synchronized php-1.28.0-wmf.23/extensions/GlobalBlocking/: Deploy fix for T149232 to unblock the train refs T147517 (duration: 00m 51s)

Stashbot mentioned this in T147517: MW-1.28.0-wmf.23 deployment blockers.Oct 26 2016, 8:28 PM
• mmodell closed this task as Resolved.Oct 26 2016, 8:29 PM
ReleaseTaggerBot added projects: MW-1.28-release (WMF-deploy-2016-10-25_(1.28.0-wmf.23)), MW-1.29-release (WMF-deploy-2016-11-01_(1.29.0-wmf.1)).Oct 26 2016, 9:00 PM
ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2016-11-08_(1.29.0-wmf.2)).Nov 2 2016, 4:01 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL