Page MenuHomePhabricator

[bug] globalblocking fatal in 1.28.0-wmf.23 -
Closed, ResolvedPublic

Description

reproduce:

https://www.mediawiki.org/w/api.php?bgip=127.0.4.4&format=json&action=query&maxlag=5&bgprop=address&list=globalblocks&bglimit=1

seems related to: https://gerrit.wikimedia.org/r/#/c/316226/

log error:

{"id":"WBD7xApAIEAAADA-fP0AAAFQ","type":"BadMethodCallException","file":"/srv/mediawiki/php-1.28.0-wmf.23/extensions/GlobalBlocking/includes/api/ApiQueryGlobalBlocks.php","line":98,"message":"Call to a member function buildLike() on a non-object (null)","

Event Timeline

Matanya created this task.Oct 26 2016, 6:55 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 26 2016, 6:55 PM
Matanya updated the task description. (Show Details)Oct 26 2016, 6:59 PM
Matanya added a subscriber: Glaisher.

Issue is ApiQueryGlobalBlocks::execute doesn't define $dbr.

Change 318158 had a related patch set uploaded (by Dereckson):
Invoke database connection in ApiQueryGlobalBlocks::execute

https://gerrit.wikimedia.org/r/318158

Change 318160 had a related patch set uploaded (by 20after4):
Invoke database connection in ApiQueryGlobalBlocks::execute

https://gerrit.wikimedia.org/r/318160

Change 318158 merged by jenkins-bot:
Invoke database connection in ApiQueryGlobalBlocks::execute

https://gerrit.wikimedia.org/r/318158

Change 318160 merged by jenkins-bot:
Invoke database connection in ApiQueryGlobalBlocks::execute

https://gerrit.wikimedia.org/r/318160

Mentioned in SAL (#wikimedia-operations) [2016-10-26T20:28:42Z] <twentyafterfour@tin> Synchronized php-1.28.0-wmf.23/extensions/GlobalBlocking/: Deploy fix for T149232 to unblock the train refs T147517 (duration: 00m 51s)

mmodell closed this task as Resolved.Oct 26 2016, 8:29 PM