Page MenuHomePhabricator

Illegal and unheralded removal of MapSourcesHooks::wfgeoLink function hook
Closed, ResolvedPublic

Description

The wfgeoLink function hook in MapSources.hooks.php was removed without telling this to the community. Why you did this? This hook was used in our articles about 30.000 times at the German Wikivoyage to display the coordinates and link to the Mapsources special page! Now all is destroyed! See for instance the indicators on the articles!

Example: https://de.wikivoyage.org/wiki/Luxor

https://phabricator.wikimedia.org/rEMSOc44731d699d0964f7f1c8be84f5cf8c677a3b2ef

Event Timeline

Restricted Application added a project: Discovery. · View Herald TranscriptOct 27 2016, 8:32 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
RolandUnger triaged this task as High priority.Oct 27 2016, 8:32 AM

Change 318342 had a related patch set uploaded (by MaxSem):
Revert the removal of {{#geolink:}}

https://gerrit.wikimedia.org/r/318342

Change 318342 merged by jenkins-bot:
Revert the removal of {{#geolink:}}

https://gerrit.wikimedia.org/r/318342

Change 318343 had a related patch set uploaded (by MaxSem):
Revert the removal of {{#geolink:}}

https://gerrit.wikimedia.org/r/318343

Change 318343 merged by jenkins-bot:
Revert the removal of {{#geolink:}}

https://gerrit.wikimedia.org/r/318343

TLDR: I screwed up, and I apologize.

Long version: we've been planning a <slippymap> removal for a while, in process all the instances were identified and communities informed a month in advance. However, for {{#geolink:}}, I missed that it was used on dewikivoyage, so it was removed as unused. Because we didn't know it was used, no community announcement was done. How I missed it? I have no idea. Most likely, I missed the German version when I was going through Wikivoyages looking for usages.

I'm deploying a revert right now, sorry once again.

MaxSem closed this task as Resolved.Oct 27 2016, 7:10 PM