Hmm I'm not seeing the "becauseYouReadSeedsDataSource" actually being used anywhere aside from tests...

Tap for animation:

Haven't been able to repro the empty section issue, but the "Hide this suggestion" not taking until refresh is reproducible.

Ah I may have figured out what happened with empty sections...

It looks like the "No internet connection" placeholder isn't showing. Here's what you see from clean install w/o internet connection:

I'm guessing I restarted the app after having read something new, but I didn't have a connection when I restarted (I had changed rooms and unplugged from wired connection without enabling WiFi), so the feed tried to add because you read items, but there was no connection and so I just saw the "because you read" header and footer with nothing in between.

To test:

1. Open app
2. Save an article
3. Pull to refresh the feed
4. Find the recommendation section for the article that was just saved
5. Tap the more menu in the upper right of the section
6. Tap the “hide” option
7. Verify the section disappears from the feed

Tested on iPhone 6S (iOS 10.0.1), and Wikipedia app 5.3.0 (966). This is still an issue, I can test again when the next build arrives in TestFlight.

@Nicholas.tsg sorry this isn’t in the current beta… will move over when it is available

See T149378#2760711

for testing steps.

Tested on iPhone 6S (iOS 10.0.1), and Wikipedia app 5.3.0 (981). This is still an issue, attached is a video of the results of Steps 5 to 7 that I got using my credentials, after tapping the “hide” option the app crashed.

Tested on iPhone 6S (iOS 10.0.1), and Wikipedia app 5.3.0 (992). This is fixed on the latest build.