Maniphest T149388

Fix Explore button localization issue
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Mhurd
	Oct 28 2016, 12:03 AM

Tags

Referenced Files

	F4678266: T149388.PNG
	Oct 30 2016, 10:40 PM

	F4671618: 9107d280-9c67-11e6-8fa2-54f56db82f34.png
	Oct 28 2016, 8:51 PM

	F4671614: 9fa409a8-9c67-11e6-85bf-f2c2c61a49c8.png
	Oct 28 2016, 8:51 PM

	F4668517: Screen Shot 2016-10-27 at 4.50.12 PM.png
	Oct 28 2016, 12:03 AM

Subscribers

Description

Screen Shot 2016-10-27 at 4.50.12 PM.png (1×974 px, 215 KB)

Related Objects

Mentioned In: rAPIOSe973a25147ea: Merge pull request #999 from wikimedia/bug/explore-button-localization/T149388
rAPIOS711b4695d90c: Merge branch 'develop' into bug/explore-button-localization/T149388
rAPIOS74baabc4635b: Merge branch 'bug/explore-button-localization/T149388' of github.com…

Event Timeline

Mhurd created this task.Oct 28 2016, 12:03 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 28 2016, 12:03 AM

https://github.com/wikimedia/wikipedia-ios/pull/999

Mhurd moved this task from Doing to Needs Code Review on the iOS-app-v5.3.0-Welsh-Dragon board.Oct 28 2016, 12:06 AM

JoeWalsh mentioned this in rAPIOS74baabc4635b: Merge branch 'bug/explore-button-localization/T149388' of github.com….Oct 28 2016, 12:15 PM

JoeWalsh mentioned this in rAPIOS711b4695d90c: Merge branch 'develop' into bug/explore-button-localization/T149388.

JoeWalsh mentioned this in rAPIOSe973a25147ea: Merge pull request #999 from wikimedia/bug/explore-button-localization/T149388.

==Testing criteria==

On either iPhone or iPad, switch device language to Hebrew
Ensure the Bottom right "Explore" icon text is in Hebrew

It should look like this...

9fa409a8-9c67-11e6-85bf-f2c2c61a49c8.png (1×974 px, 212 KB)

Not like this...

9107d280-9c67-11e6-8fa2-54f56db82f34.png (1×974 px, 215 KB)

Mhurd moved this task from Needs Code Review to Needs QA on the iOS-app-v5.3.0-Welsh-Dragon board.Oct 28 2016, 8:51 PM

• JMinor triaged this task as Medium priority.Oct 28 2016, 10:35 PM

Tested on iPhone 6S (iOS 10.0.1), and Wikipedia app 5.3.0 (966). This is fixed as the attached screencap shows.

T149388.PNG (1×750 px, 141 KB)

Nicholas.tsg moved this task from Needs QA to Ready for PM Signoff on the iOS-app-v5.3.0-Welsh-Dragon board.Oct 30 2016, 10:40 PM

• JMinor closed this task as Resolved.Oct 31 2016, 6:06 PM