Page MenuHomePhabricator

Announce graph frames to the community
Closed, DeclinedPublic


As part of T147768: Add a frame and caption text to <graph>, not only new features will be added, but default appearance for graphs will change.

Before and after:

We need to communicate this to communities. In case there are problems with this change, we would need to make certain modifications.

Event Timeline

MaxSem created this task.Oct 28 2016, 11:50 PM
Restricted Application added a project: Discovery. · View Herald TranscriptOct 28 2016, 11:50 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Yurik added a subscriber: Yurik.Oct 29 2016, 3:39 AM

I think we should decide T147768#2753642 first.

Qgil removed Ckoerner as the assignee of this task.Oct 31 2016, 12:36 PM
Qgil added subscribers: CKoerner_WMF, Ckoerner, Qgil.

@Ckoerner is a volunteer. :)

Before reassigning it... @CKoerner_WMF, are you committing to this task for this quarter? You have quite a bit on your plate. Or is this a subtask of T144512?

I think we should decide T147768#2753642 first.

If this is true, then that task should be marked as blocker.

It's a bit dry, but here is a rough draft of the announcement of this update to graphs.

It's a bit dry, but here is a rough draft of the announcement of this update to graphs.

You may want a screenshot:

Note: If needed, I'm happy to give you a screenshot for any graph on this page:

In addition, and in case you missed it, you may want to go over this comment that describes how the service and its different attributes work, and add that to your draft ;)

CKoerner_WMF triaged this task as Normal priority.Nov 8 2016, 9:35 PM
debt added a subscriber: debt.Nov 9 2016, 3:43 PM

Or this sample...

Yurik moved this task from Backlog to To-do on the Maps-Sprint board.Nov 9 2016, 7:44 PM

Screenshot and clear descriptions of new attributes have been added.

Let me know what you think. If this looks good we can share via mailing lists (or other ideas if you have them).

Yurik added a comment.Nov 15 2016, 4:25 PM

@CKoerner_WMF thanks, i cleaned it up a bit, looks good.

If we're in agreement I can post this to discovery, and wikitech mailing lists. Please let me know.

I've thought about this. Let's stick with the plan of releasing the update to add the frame, and then post this message. Announcing in advance without a sound date has the potential for folks not being in the loop when we do launch and us having to repost again.

debt added a comment.Dec 13 2016, 3:51 PM

Thanks for the update, @CKoerner_WMF - it appears that there is still work to be done anyway on this feature: as the latest check-in has a -2 on it.

Yurik added a comment.Dec 13 2016, 4:31 PM

@debt, the -2 is due to this very bug. We will be waiting for a while.

@MaxSem: Oct 28 7:52 PM
Patch Set 15: Code-Review-2
Let's wait for communities to be informed before merging, as tracked in T149462.

Yurik removed a project: Maps.Dec 15 2016, 4:39 AM

@Yurik I'm confused. Are we stalled on that gerrit change or do I have the timeline backwards - fix then inform communities or the other way around?

Yurik added a comment.Dec 21 2016, 4:57 PM

Max blocked the merge until the community is notified. The-2 is a precaution against accidental merge and deployment

So it looks like I misunderstood. I should publish this message which is done and then the team will push the change to production.

@Yurik if that's right I can post the message.

Yurik added a comment.Jan 3 2017, 10:42 PM

Seems we might need to pause on this - it appears our implementation will not work in some cases - graph's width/height is not very deterministic, which will break the frame :(

debt added a comment.Jan 4 2017, 7:34 PM

Updating the ticket to show the progression - see this note here.

CKoerner_WMF changed the task status from Open to Stalled.Jan 4 2017, 7:35 PM
CKoerner_WMF moved this task from To-do to Stalled/Waiting on the Maps-Sprint board.
CKoerner_WMF lowered the priority of this task from Normal to Low.Apr 3 2017, 4:41 PM
CKoerner_WMF changed the task status from Stalled to Open.Jun 6 2017, 9:17 PM
CKoerner_WMF removed CKoerner_WMF as the assignee of this task.

Adding to the backlog and un-assigning. I'm not sure what the plans are for Interactive work at the moment.

Moving off the sprint board - the Discovery team won't be able to finish this work at this time.

MaxSem closed this task as Declined.Feb 16 2018, 8:44 PM

Does not matter anymore.